Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-contain-1] Minor editorial #5806

Closed
svgeesus opened this issue Dec 18, 2020 · 5 comments
Closed

[css-contain-1] Minor editorial #5806

svgeesus opened this issue Dec 18, 2020 · 5 comments
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-contain-1 Testing Unnecessary Memory aid - issue doesn't require tests Tracked in DoC

Comments

@svgeesus
Copy link
Contributor

svgeesus commented Dec 18, 2020 •
edited
Loading

@frivoal This wording

Given than the effect on is identical, this allows implementations not to store the precise syntax through which this was achived

is a bit odd, and also has a typo (achived). The effect on what? Also the avoidance of the split infinitive, although theoretically correct, sounds clumsy.

Perhaps

Given that the effect is identical, this allows implementations to not store the precise syntax through which this was achieved
@svgeesus
Copy link
Contributor Author

(This is not a blocker for publication, just a suggestion)

@w3c w3c deleted a comment from florian Dec 18, 2020
@frivoal
Copy link
Collaborator

frivoal commented Dec 20, 2020 •
edited
Loading

"on" looks like stray text, and should indeed be deleted. What's wrong with unsplit infinitives? Sounds fine to me… But not being a native speaker, "sounds fine to me" isn't a very good guideline to go by.

frivoal added a commit that referenced this issue Dec 20, 2020
@frivoal
[css-contain-1] remove stray text
b7363fd 
See #5806
@svgeesus
Copy link
Contributor Author

Also "Given than" instead of "Given that".

frivoal added a commit that referenced this issue Dec 21, 2020
@frivoal
[css-contain-1] Fix typo (#5806)
26aa42d
@frivoal
Copy link
Collaborator

frivoal commented Dec 21, 2020

Also "Given than" instead of "Given that".

Done.

@svgeesus svgeesus added Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. labels Dec 21, 2020
@svgeesus
Copy link
Contributor Author

OK, great!

@frivoal frivoal added Tracked in DoC Testing Unnecessary Memory aid - issue doesn't require tests labels Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-contain-1 Testing Unnecessary Memory aid - issue doesn't require tests Tracked in DoC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frivoal @svgeesus