Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cssom][css-variable] Methods of CSSStyleDeclaration interface doesn't handle custom properties properly #630

Closed
upsuper opened this issue Oct 20, 2016 · 1 comment · Fixed by #631
Labels
css-variables-1 Current Work cssom-1 Current Work

Comments

@upsuper
Copy link
Member

upsuper commented Oct 20, 2016

In all methods which take a property parameter, there is a very early step says:

Let property be property converted to ASCII lowercase.

However, name of custom properties is case-sensitive, so this step would mess up custom properties.

In addition to that, some of the methods also have:

If property is not a case-sensitive match for a supported CSS property, terminate this algorithm.

This would make the method not usable for custom properties.

I think the solution is to recognize custom properties in an early step, and only apply the above steps to non-custom properties.

@upsuper
Copy link
Member Author

upsuper commented Oct 21, 2016

Looks like it is a dup of #580.

@upsuper upsuper closed this as completed Oct 21, 2016
SimonSapin pushed a commit that referenced this issue Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-variables-1 Current Work cssom-1 Current Work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant