-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-fonts-4] Should font-variant-emoji
be included in the font-variant
shorthand?
#7315
Comments
Pinging @litherum @svgeesus @nattokirai as editors of Fonts 4 ... was this just an editorial oversight, or is it an issue that needs a CSSWG discussion to sort out? |
I believe this was an oversight, we forgot to update it. I think renaming |
Yeah, font-variant-emoji came later, doesn’t use the same implementation mechanism as the rest of the font-variant longhands, and used to be named something like emoji-presentation (but got renamed to its current name). I don’t know why it got renamed to its current name. As things lie now, I don’t think I have an opinion on this shorthand issue. |
Agreed, from an implementation POV it's rather different; however, I think that from an author's POV using So to my mind, the (I don't care strongly one way or the other, really, this just seems most logical to me. But mostly, I'd like the spec to be clear on it so that we all know what to expect.) |
I agree with @jfkthame that from an authoring point of view it is consistent with the other font-variant properties and thus, the renaming that happened was correct. I therefore think it should be included in the shorthand, and reset when the shorthand is used. I also (still) think we should |
It used to be called |
Indeed, the previous CSS WG discussion where we changed the name did not consider the impact on the shorthand at all (it was mostly about the values, which we didn't resolve on until later). |
We didn't get to this on today's call, can we resolve here in the issue? @jfkthame suggested three things:
My answers to that are yes, yes, and yes. It was just an editing oversight that this wasn't already done. @litherum stated they don't have an opinion on 2. And it was their issue that resulted in 1. @litherum any opinions on 3. ? |
I have no opinions. |
Hearing no objections, I plan to make the edits as @jfkthame suggested. |
@svgeesus, can you please update the csswg-drafts/css-fonts-4/Overview.bs Line 6612 in a2e50cb
EDIT: fixed by 87a2abd. |
The spec text for the
font-variant
property says that itand its value syntax almost reflects this.
However, it does not include the keywords
auto | text | emoji | unicode
that would be the possible values offont-variant-emoji
as specified in the Color Font Support section of the spec.Is this an accidental omission that should simply be added to the
font-variant
values, or isfont-variant-emoji
not supposed to be a subproperty offont-variant
, despite its name?My current opinion: the
-emoji
values should be supported by thefont-variant
shorthand; they don't clash with values of any of the other subproperties, and I think authors would naturally assume this should work.However, this does raise the point that all the other
font-variant
subproperties have the initial valuenormal
, so that it's very natural forfont-variant: normal
to set them all to their initial values of the same name. Butfont-variant-emoji
is currently specified to have initial valueauto
, and has nonormal
. It would still be possible forfont-variant: normal
to reset it to its initial value (auto
), but this suddenly seems less intuitive. So I wonder if we should rename this value tonormal
for consistency with the otherfont-variant-*
subproperties? (As far as I'm aware, no-one has yet shipped support forfont-variant-emoji
, so renaming the value should be possible without compatibility concerns.)The text was updated successfully, but these errors were encountered: