Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-values] add 'revert' and 'revert-layer' to list of CSS-wide keywords #7439

Closed
dbaron opened this issue Jun 30, 2022 · 2 comments · Fixed by g-plane/raffia#3
Closed

[css-values] add 'revert' and 'revert-layer' to list of CSS-wide keywords #7439

dbaron opened this issue Jun 30, 2022 · 2 comments · Fixed by g-plane/raffia#3
Labels
Closed Accepted as Editorial css-values-3 css-values-4 Current Work css-values-5

Comments

@dbaron
Copy link
Member

dbaron commented Jun 30, 2022

css-values lists the CSS-wide keywords. This definition is important because it has implications for things like what is allowed in custom identifiers.

css-cascade-4 adds the 'revert' keyword and css-cascade-5 adds the 'revert-layer' keyword. Should these be added to the list of CSS-wide keywords?

I'd note that Blink already mostly implements this change (modulo a bug).

I haven't checked other implementations.
@tabatkins
Copy link
Member

Yes, they should be.

@yisibl
Copy link
Contributor

yisibl commented Jul 5, 2022

I have a similar issue: #7170

@yisibl yisibl mentioned this issue Jul 15, 2022
Open
@yisibl yisibl mentioned this issue Sep 19, 2022
Closed
@liruifengv liruifengv mentioned this issue Sep 25, 2022
Merged
fantasai added a commit that referenced this issue Oct 10, 2022
@fantasai
[css-values][css-cascade] Refactor CSS-wide keyword definitions #7439
9b95cab 
* Move descriptive text from Values to Cascade
* Define Cascade as source of keyword definitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted as Editorial css-values-3 css-values-4 Current Work css-values-5
Projects
None yet
Milestone
No milestone
4 participants
@dbaron @tabatkins @fantasai @yisibl