Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-fonts-4] Clarify definition of CSSFontFaceRule #8394

Closed
cdoublev opened this issue Feb 2, 2023 · 1 comment
Closed

[css-fonts-4] Clarify definition of CSSFontFaceRule #8394

cdoublev opened this issue Feb 2, 2023 · 1 comment

Comments

@cdoublev
Copy link
Collaborator

cdoublev commented Feb 2, 2023

I think this sentence is an oversight in CSSFontFaceRule definition:

The (now superseded) DOM Level 2 Style specification defined a different variant of this rule. This definition supersedes that one.

DOM Level 2 defines the exact same interface.

This commit defined CSSFontFaceRule descriptors as attributes with the above sentence. This commit removed the attributes but not the above sentence.

I do noy know how CSSFontFaceRule.style is supposed to work but this sentence could be replaced by an issue saying it is under consideration.

I guess it depends on #5649 but more recent at-rules seem to have been defined with descriptors as attributes, whereas #5649 resolved on defining different interfaces for declarations blocks that expose a different set of descriptors/properties.

@svgeesus
Copy link
Contributor

svgeesus commented Feb 3, 2023

Thanks for spotting. The sentence is indeed leftover from the time a different interface was in CSS Fonts 3, and then moved over to 4, before being deleted and replaced by the actually-implemented one from DOM 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants