Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-color-5] relative color() function isn't immediately clear #8841

Closed
romainmenke opened this issue May 13, 2023 · 3 comments
Closed

[css-color-5] relative color() function isn't immediately clear #8841

romainmenke opened this issue May 13, 2023 · 3 comments
Assignees
Labels
Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-color-5 Color modification

Comments

@romainmenke
Copy link
Member

romainmenke commented May 13, 2023

As far as I can tell there isn't any issue in the specification, it just isn't easy to to immediately understand color() in terms of relative color syntax.


different naming :

At first this seems as if it is a different aspect of color(), and it isn't clear that relative color syntax for predefined color spaces is also defined within this section.


missing/confusing examples :

Examples 28/29 focus on gamut mapping, valid values, ...

But they follow the section that explains relative color syntax for the color() function.

There is no example of relative color syntax for the color() function.


Is it possible that there was some restructuring done here at some point and that not everything landed exactly where/how it was intended?

@svgeesus
Copy link
Contributor

svgeesus commented Jun 1, 2023

Yeah that whole section starting

A color which is either an invalid color or an out of gamut color can’t be displayed.

is exactly the same as in CSS Color 4, looks like it was copied over with a view to changing it maybe, but it doesn't belong there.

@svgeesus
Copy link
Contributor

svgeesus commented Jun 5, 2023

@romainmenke could you take a look at the now-renamed Specifying Predefined and Custom Color Spaces: the color() Function to check your issues have been addressed?

The confusing duplicate section has been deleted, and an example added.

@romainmenke
Copy link
Member Author

Much clearer, thank you so much.
This is good to close for me 🙇

@svgeesus svgeesus added Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. and removed Needs Edits Needs Example or Figure labels Jun 5, 2023
@svgeesus svgeesus closed this as completed Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-color-5 Color modification
Projects
None yet
Development

No branches or pull requests

2 participants