Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flexbox] Use flex-order first or document-order first item's baseline? #995

Closed
fantasai opened this issue Feb 1, 2017 · 5 comments
Closed

Comments

@fantasai
Copy link
Collaborator

@fantasai fantasai commented Feb 1, 2017

In #197, it was noted that there's an inconsistency between Grid and Flexbox in whether the baseline is taken from the first item in document order or visual order. Grid clearly defines using the visual (grid) order; flexbox should probably account for 'order' and 'flex-direction' as well.

@SelenIT
Copy link
Collaborator

@SelenIT SelenIT commented Feb 1, 2017

Using visually first flex item definitely makes more sense. As my quick test suggests, browsers also seem to consistently use the visually first item's baseline as a flex container baseline.

@astearns
Copy link
Member

@astearns astearns commented Feb 22, 2017

Would this be visually first or flex-order first? Given a dom-order 1-2-3 that's flex-ordered 2-1-3 then displayed in a reverse flex container so that it appears on the page as 3-1-2, which item is 'first'?

@fantasai
Copy link
Collaborator Author

@fantasai fantasai commented Feb 23, 2017

That's a good question, and I think it should be visually first. The goal of first-baseline alignment is to align the visually first line of text; last-baseline alignment the visually last. Aligning a random line of text somewhere in the middle of the box isn't helpful.

@astearns
Copy link
Member

@astearns astearns commented Mar 1, 2017

RESOLVED: take the visually first line when considering baseline alignment in flexboxes

@tabatkins
Copy link
Member

@tabatkins tabatkins commented Mar 14, 2017

Fixed in 620eb8c.

@tabatkins tabatkins closed this Mar 14, 2017
fantasai added a commit that referenced this issue Sep 13, 2017
… of our changes before we publish, so I get to notice nonsensical errors like this one in our edits for fixing #995. Correct use of start/end vs first/last in definition of baselines, cuz the original fix was random and not correct. >_<
@fantasai fantasai added this to the Published css-flexbox-1 2017-10-19 milestone Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants