Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-overflow-3] Clarify that scripts can also scroll a scroll container #10048

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

tcaptan-cr
Copy link
Contributor

This clarification was precipitated by an intersection observer issue in order to avoid confusion over who can scroll the overflow area of a scroll container.

@tcaptan-cr
Copy link
Contributor Author

Please take a look @fantasai & @szager-chromium.

Copy link
Member

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this rewording reads a little bit too much like it's trying to define "scrollable overflow area", which it isn't. There are also things that are neither clearly user scrolls nor page scripts that can cause scrolling, such as UA features like find-in-page being used by the user.

This might actually be a good use case for the passive voice, since it lets us avoid answering the question of who's doing the scrolling. e.g., "that allows clipped parts of its scrollable overflow area to be scrolled into view".

(Also, it looks like this section uses tabs for indentation; please don't convert just a few lines to spaces.)

@tcaptan-cr
Copy link
Contributor Author

I think this rewording reads a little bit too much like it's trying to define "scrollable overflow area", which it isn't. There are also things that are neither clearly user scrolls nor page scripts that can cause scrolling, such as UA features like find-in-page being used by the user.

This might actually be a good use case for the passive voice, since it lets us avoid answering the question of who's doing the scrolling. e.g., "that allows clipped parts of its scrollable overflow area to be scrolled into view".

(Also, it looks like this section uses tabs for indentation; please don't convert just a few lines to spaces.)

That sounds good to me. Thank you David!
I updated it based on your feedback.

@dbaron dbaron merged commit 8709735 into w3c:main Mar 15, 2024
1 check passed
@fantasai
Copy link
Collaborator

fantasai commented Mar 25, 2024

Wording looks good (thanks for the review @dbaron!), but y'all dropped the cross-link! Fixed in 047ab49 :)

@tcaptan-cr
Copy link
Contributor Author

Wording looks good (thanks for the review @dbaron!), but y'all dropped the cross-link! Fixed in 047ab49 :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants