Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1241 by adding a number-calc microgrammar #1244

Merged
merged 1 commit into from
Apr 19, 2017

Conversation

FremyCompany
Copy link
Contributor

Another option would be to allow any calc-value again, and let the prose that follows disambiguate like we do for the * products.

Another option would be to allow any calc-value again, and let the prose that follows disambiguate like we do for the * products.
Copy link
Member

@tabatkins tabatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this change; the issue in #1241 is invalid.

@tabatkins tabatkins merged commit 40dcee1 into master Apr 19, 2017
@tabatkins tabatkins deleted the possible-fix-for-1241 branch April 19, 2017 06:00
triple-underscore added a commit to triple-underscore/triple-underscore.github.io that referenced this pull request Apr 19, 2017
@syncbot syncbot restored the possible-fix-for-1241 branch May 1, 2017 20:05
@plinss plinss deleted the possible-fix-for-1241 branch August 2, 2017 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants