[css-text-3] Spaces don't hang when break-spaces is specified #2612
Conversation
css-text-3/Overview.bs
Outdated
| but have 'white-space' set to ''pre-wrap'': | ||
| <ul> | ||
| <li>If the value of 'overflow-wrap' is ''overflow-wrap/normal'' or ''overflow-wrap/break-word'' | ||
| (i.e. it does not include ''break-spaces'') |
There was a problem hiding this comment.
If 'overflow-wrap' does not specify ''break-spaces''
css-text-3/Overview.bs
Outdated
| Note: Hanging the white space rather than collapsing it | ||
| allows users to see the space when selecting or editing text. | ||
| <li>Otherwise | ||
| (i.e. 'overflow-wrap' property includes ''break-spaces''), |
css-text-3/Overview.bs
Outdated
| allows users to see the space when selecting or editing text. | ||
| <li>Otherwise | ||
| (i.e. 'overflow-wrap' property includes ''break-spaces''), | ||
| hanging or collapsing the advance width of is not allowed. |
There was a problem hiding this comment.
“of is” is not grammatical.
css-text-3/Overview.bs
Outdated
| (i.e. 'overflow-wrap' property includes ''break-spaces''), | ||
| hanging or collapsing the advance width of is not allowed. | ||
| The end-of-lines spaces that would overflow the line are | ||
| wrapped as described in the definition of the ''break-spaces'' value. |
There was a problem hiding this comment.
Normatively, this doesn't belong here. We've already broken lines. If spaces needed to get wrapped, they've already gotten wrapped.
css-text-3/Overview.bs
Outdated
| @@ -1246,14 +1252,11 @@ Line Breaking Details</h3> | |||
| must be broken after the last white space character that would fit the line, | |||
There was a problem hiding this comment.
Here is where you specify that the spaces must take up space on the line.
css-text-3/Overview.bs
Outdated
| the rules of ''break-spaces'' do not introduce any additional line break, | ||
| and that space does overflow and <a>hang</a>. | ||
| Also, if the line length is so short that even a single space does not fit, | ||
| As spaces do not hang, |
There was a problem hiding this comment.
Otherwise this phrase can't be a reminder of that fact.
|
@fantasai Thanks for the review, I think it is now fixed. Can you confirm (and approve), or provide further feedback? |
css-text-3/Overview.bs
Outdated
| * Any sequence of <a>preserved</a> white space | ||
| that would otherwise overflow the line and <a>hang</a> or be collapsed as per <a href="#white-space-phase-2">Trimming and Positioning</a> | ||
| must be broken after the last white space character that would fit the line, | ||
| or after the first white space in the sequence if none would fit. |
There was a problem hiding this comment.
Replace this second clause with “A line breaking opportunity exists after every preserved white space character, including between white space characters” or somesuch. We're not dictating where the line breaks here, we're just altering where it's allowed to break.
|
Approved. I'm gonna let you merge, please squash and rebase if you can. |
Closes #2465