Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-page-3] Revert to ED #4145

Merged
merged 1 commit into from
Jul 27, 2019
Merged

[css-page-3] Revert to ED #4145

merged 1 commit into from
Jul 27, 2019

Conversation

xfq
Copy link
Member

@xfq xfq commented Jul 23, 2019

Post publication edit. Also remove the generated HTML.

@xfq xfq added the css-page-3 Current Work label Jul 23, 2019
frivoal
frivoal requested changes Jul 26, 2019
View reviewed changes
Copy link
Collaborator

@frivoal frivoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edit to Overview.bs is fine, but instead of updating Overview.html, just delete it, and it will be regenerated server-side.

@xfq
Copy link
Member Author

xfq commented Jul 27, 2019

The edit to Overview.bs is fine, but instead of updating Overview.html, just delete it, and it will be regenerated server-side.

Yep. That's what I did in this PR.

@frivoal frivoal merged commit 557528c into master Jul 27, 2019
@frivoal
Copy link
Collaborator

frivoal commented Jul 27, 2019

That's what I did in this PR.

Oops, sorry, I looked a the diff wrong, and somehow thought that you had regenerated it. Merged.

@frivoal frivoal deleted the xfq/css-page-3 branch July 27, 2019 08:08
@syncbot syncbot restored the xfq/css-page-3 branch September 16, 2019 07:54
@plinss plinss deleted the xfq/css-page-3 branch September 16, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frivoal frivoal frivoal approved these changes

Assignees
No one assigned
Labels
css-page-3 Current Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xfq @frivoal