Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-overflow-3] #3779 Do not propagate overflow from boxless elements. #4148

Merged
merged 3 commits into from
Jul 30, 2019
Merged

[css-overflow-3] #3779 Do not propagate overflow from boxless elements. #4148

merged 3 commits into from
Jul 30, 2019

Conversation

lilles
Copy link
Member

@lilles lilles commented Jul 24, 2019

Resolution: #3779 (comment)

@lilles lilles requested a review from fantasai July 24, 2019 13:45
frivoal
frivoal requested changes Jul 26, 2019
View reviewed changes
Copy link
Collaborator

@frivoal frivoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. Just few clarifications, and it'll be good to merge.

css-overflow-3/Overview.bs Outdated Show resolved Hide resolved
css-overflow-3/Overview.bs Outdated Show resolved Hide resolved
lilles and others added 2 commits July 29, 2019 08:59
@lilles @frivoal
applied -> propagated
b40bd0f 
Co-Authored-By: Florian Rivoal <git@florian.rivoal.net>
@lilles @frivoal
canvas -> viewport
ec930e3 
Co-Authored-By: Florian Rivoal <git@florian.rivoal.net>
@frivoal frivoal merged commit 0910142 into w3c:master Jul 30, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Jul 30, 2019
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 30, 2019
@chromium-wpt-export-bot
Overflow tests no longer tentative after spec edit.
3edd168 
PR landed: w3c/csswg-drafts#4148

Bug: 987207
Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 31, 2019
Overflow tests no longer tentative after spec edit.
cb86b8e 
PR landed: w3c/csswg-drafts#4148

Bug: 987207
Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682679}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 31, 2019
@chromium-wpt-export-bot
Overflow tests no longer tentative after spec edit.
69df604 
PR landed: w3c/csswg-drafts#4148

Bug: 987207
Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682679}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 31, 2019
@chromium-wpt-export-bot
Overflow tests no longer tentative after spec edit.
6915274 
PR landed: w3c/csswg-drafts#4148

Bug: 987207
Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682679}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 5, 2019
@moz-wptsync-bot
Bug 1570181 [wpt PR 18185] - Overflow tests no longer tentative after…
6c7019d 
… spec edit., a=testonly

Automatic update from web-platform-tests
Overflow tests no longer tentative after spec edit.

PR landed: w3c/csswg-drafts#4148

Bug: 987207
Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682679}

--

wpt-commits: 69152741bde0991a88c05a8fb98437bc44c90821
wpt-pr: 18185


--HG--
rename : testing/web-platform/tests/css/css-overflow/overflow-body-propagation-001.tentative.html => testing/web-platform/tests/css/css-overflow/overflow-body-propagation-001.html
rename : testing/web-platform/tests/css/css-overflow/overflow-body-propagation-002.tentative.html => testing/web-platform/tests/css/css-overflow/overflow-body-propagation-002.html
rename : testing/web-platform/tests/css/css-overflow/overflow-body-propagation-003.tentative.html => testing/web-platform/tests/css/css-overflow/overflow-body-propagation-003.html
rename : testing/web-platform/tests/css/css-overflow/overflow-body-propagation-004.tentative.html => testing/web-platform/tests/css/css-overflow/overflow-body-propagation-004.html
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Aug 6, 2019
@moz-wptsync-bot
Bug 1570181 [wpt PR 18185] - Overflow tests no longer tentative after…
c10f326 
… spec edit., a=testonly

Automatic update from web-platform-tests
Overflow tests no longer tentative after spec edit.

PR landed: w3c/csswg-drafts#4148

Bug: 987207
Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682679}

--

wpt-commits: 69152741bde0991a88c05a8fb98437bc44c90821
wpt-pr: 18185
natechapin pushed a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
@natechapin
Overflow tests no longer tentative after spec edit.
af375a6 
PR landed: w3c/csswg-drafts#4148

Bug: 987207
Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682679}
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1570181 [wpt PR 18185] - Overflow tests no longer tentative after…
a89de65 
… spec edit., a=testonly

Automatic update from web-platform-tests
Overflow tests no longer tentative after spec edit.

PR landed: w3c/csswg-drafts#4148

Bug: 987207
Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030
Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org>
Commit-Queue: Rune Lillesveen <futharkchromium.org>
Cr-Commit-Position: refs/heads/master{#682679}

--

wpt-commits: 69152741bde0991a88c05a8fb98437bc44c90821
wpt-pr: 18185

UltraBlame original commit: 55d847ea213319d1269eb64f46b24341d7a507e7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
@marco-c
Bug 1570181 [wpt PR 18185] - Overflow tests no longer tentative after…
aa6406f 
… spec edit., a=testonly

Automatic update from web-platform-tests
Overflow tests no longer tentative after spec edit.

PR landed: w3c/csswg-drafts#4148

Bug: 987207
Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030
Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org>
Commit-Queue: Rune Lillesveen <futharkchromium.org>
Cr-Commit-Position: refs/heads/master{#682679}

--

wpt-commits: 69152741bde0991a88c05a8fb98437bc44c90821
wpt-pr: 18185

UltraBlame original commit: 55d847ea213319d1269eb64f46b24341d7a507e7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1570181 [wpt PR 18185] - Overflow tests no longer tentative after…
922fbae 
… spec edit., a=testonly

Automatic update from web-platform-tests
Overflow tests no longer tentative after spec edit.

PR landed: w3c/csswg-drafts#4148

Bug: 987207
Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030
Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org>
Commit-Queue: Rune Lillesveen <futharkchromium.org>
Cr-Commit-Position: refs/heads/master{#682679}

--

wpt-commits: 69152741bde0991a88c05a8fb98437bc44c90821
wpt-pr: 18185

UltraBlame original commit: 55d847ea213319d1269eb64f46b24341d7a507e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frivoal frivoal frivoal approved these changes

@fantasai fantasai Awaiting requested review from fantasai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilles @frivoal