Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-mediaqueries] Add 'prefers-reduced-data' (addresses #2370) #4575

Merged
merged 5 commits into from
Jan 23, 2020
Merged

[css-mediaqueries] Add 'prefers-reduced-data' (addresses #2370) #4575

merged 5 commits into from
Jan 23, 2020

Conversation

huijing
Copy link
Contributor

@huijing huijing commented Dec 9, 2019

Content pulled from discussion within #2370

Content pulled from discussion within #2370
@frivoal
Copy link
Collaborator

frivoal commented Dec 9, 2019

Thanks @huijing, this looks good. One suggestion: could you add a note saying that User Agents may consider setting this based on the same user or system preference as they use to set the Save-Data HTTP request header?

@frivoal frivoal self-assigned this Dec 9, 2019
Copy link

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!! :)
non-owner LGTM other than a couple of nits

mediaqueries-5/Overview.bs Outdated Show resolved Hide resolved
mediaqueries-5/Overview.bs Outdated Show resolved Hide resolved
@media (prefers-reduced-data: reduce) {
/* Save-Data: On */
.image {
background-image: url("images/heavy.jpg");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "light" and "heavy" switched places :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries :)

or a setting controlled by the User Agent.

Note: User Agents may consider setting this based on the same user
or system preference as they use to set the Save-Data HTTP request

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can point to https://wicg.github.io/savedata/ as a reference link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added link.

@frivoal frivoal merged commit f3ad439 into w3c:master Jan 23, 2020
@frivoal
Copy link
Collaborator

frivoal commented Jan 23, 2020

Merged! thanks @huijing

@yoavweiss
Copy link

Yay!! 🎉

@ryantownsend
Copy link

Super excited about this! 😁

@huijing
Copy link
Contributor Author

huijing commented Jan 23, 2020

omg, this is the highlight of my day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants