Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid-1][css-grid-2] Replace article to main #6012

Merged
merged 3 commits into from
Feb 26, 2021

Conversation

SiarheiBobryk
Copy link
Contributor

Use main as a more suitable element in example 9.

Changes:

  • Tweak the SVG image
  • Use the main element in example 9 for CSS Grid Layout Module Level
    1
    and CSS Grid Layout Module Level 2

Before:
Screen Shot 2021-02-18 at 3 03 04 am

After:
Screen Shot 2021-02-18 at 3 04 16 am

Use `main` as a more suitable element in example 9.

Changes:
- Tweak the SVG image
- Use the `main` element in example 9 for _CSS Grid Layout Module Level
1_ and _CSS Grid Layout Module Level 2_
@tabatkins
Copy link
Member

I'm fine with this change, but it looks like you did the SVG edits in a WYSIWIG editor, which totally trashed the file with metadata; I can't merge that. The SVG should be readable and easily editable by hand, so you can swap out just the one offending word; it uses proper centered positioning, so you won't even need to adjust the position of anything.

@SiarheiBobryk
Copy link
Contributor Author

Thanks for your feedback @tabatkins!
I've used Inkscape for that. Please, could you suggest to me the best SVG editor (your opinion)?

@SiarheiBobryk
Copy link
Contributor Author

so you can swap out just the one offending word;

@tabatkins it's done!

@SiarheiBobryk
Copy link
Contributor Author

@tabatkins please check

@tabatkins tabatkins merged commit 0995a0d into w3c:main Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants