Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-fonts-5] The font-size-adjust property is applied after the size-adjust descriptor #6184

Merged
merged 1 commit into from
Apr 8, 2021
Merged

[css-fonts-5] The font-size-adjust property is applied after the size-adjust descriptor #6184

merged 1 commit into from
Apr 8, 2021

Conversation

litherum
Copy link
Contributor

@litherum litherum commented Apr 6, 2021

Fixes #6128.

jfkthame
jfkthame reviewed Apr 6, 2021
View reviewed changes
css-fonts-5/Overview.bs Outdated Show resolved Hide resolved
jfkthame
jfkthame approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@jfkthame jfkthame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo possible wording tweak.

@chrishtr
Copy link
Contributor

chrishtr commented Apr 6, 2021

LGTM. Also agree with @jfkthame 's suggested wording improvement.

@litherum litherum force-pushed the font-size-adjust-size-adjust branch from d633b76 to afbd29c Compare April 6, 2021 22:52
@litherum litherum force-pushed the font-size-adjust-size-adjust branch from afbd29c to b54acbf Compare April 6, 2021 22:58
@litherum
Copy link
Contributor Author

litherum commented Apr 8, 2021

@svgeesus do you know why the checks haven't completed yet? It's been over 24 hours.

@svgeesus svgeesus merged commit 3be42a5 into w3c:main Apr 8, 2021
@svgeesus
Copy link
Contributor

svgeesus commented Apr 8, 2021

@litherum

do you know why the checks haven't completed yet? It's been over 24 hours.

The IPR bot was broken, I reported it and it was restarted, it seems to be broken again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfkthame jfkthame jfkthame approved these changes

@svgeesus svgeesus svgeesus approved these changes

@drott drott Awaiting requested review from drott

@chrishtr chrishtr Awaiting requested review from chrishtr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[css-fonts-5] How do font-size-adjust property and size-adjust descriptor work together?
4 participants
@litherum @chrishtr @svgeesus @jfkthame