Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cssom-view] Remove "familiar with" check for move/resize methods #6300

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

domenic
Copy link
Collaborator

@domenic domenic commented May 20, 2021

Closes #1725 by removing the usage of incumbent settings object. I could find no evidence of such a check in the Blink, Gecko, or WebKit codebases. Indeed, such a check should not generally be necessary, as (unlike, e.g., window.close()) these methods are not accessible cross-origin.

Also includes various changes for things that have updated in other specs:

  • Use "this" instead of "context object"
  • Use "string is" instead of "case-sensitive"
  • Use "start node" and "start offset" instead of referring to properties of Range (or now, AbstractRange)
  • Link to the correct "event loop" definition
  • Remove redundant anchor blocks, as these days most definitions are properly exported

Closes w3c#1725 by removing the usage of incumbent settings object. I could find no evidence of such a check in the Blink, Gecko, or WebKit codebases. Indeed, such a check should not generally be necessary, as (unlike, e.g., window.close()) these methods are not accessible cross-origin.

Also includes various changes for things that have updated in other specs:

* Use "this" instead of "context object"
* Use "string is" instead of "case-sensitive"
* Use "start node" and "start offset" instead of referring to properties of Range (or now, AbstractRange)
* Link to the correct "event loop" definition
* Remove redundant anchor blocks, as these days most definitions are properly exported
@tabatkins
Copy link
Member

ping @emilio

@emilio emilio merged commit ec8ace9 into w3c:main Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cssom-view] Stop using "incumbent settings object"?
3 participants