-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-easing-2] Adding multi-step linear-interpolated easing function #7414
Conversation
@dshin-moz I've corrected the issues we discussed in the previous PR, and wrote a more solid algorithm for calculating the output for a given input (although you might be ahead of me there). I've defined how the computed value works, matching gradients, but it seems silly now I've written it down. I'll open an issue to see if we can go for something simpler. |
#7415 - to discuss the computed value |
Since we aren't overloading |
Yep. Although I'm open to bikeshedding. |
I guess I need to define that in the parsing |
|
Yeah, I kinda liked reusing |
Yeah, my experience is that short and memorable is better than semantically correct (hence why we should have used I thought using |
I'll give it some thought over the weekend. Maybe I changed it too hastily. |
Opened #7419 for the name bikeshedding |
67c7a83
to
a4c01be
Compare
Seems increasingly likely this will go back to |
6efa6c2
to
67c7a83
Compare
67c7a83
to
f621932
Compare
@jakearchibald Can you please move this PR into a fork of the repo, rather than a branch in the main repo? Having branches puts an additional load on our draft server (and when there are history changes on the branch it plays havoc with the git to hg conversion currently used by that server). (There are improvements planned for the draft server that will make this less of an issue, but we're not there just yet.) |
Shall do. I'll close this once I have the fork in place. Sorry for the trouble caused! |
ef29eae
to
67c7a83
Compare
Temporarily moved to jakearchibald#1 due to issues mentioned in #7414 (comment)
This PR defines
linear-spline()
, a way to create custom easings, as discussed in #229 (comment).TODO: