Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit specifications for correct handling of overflow:clip. #7436

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

dbaron
Copy link
Member

@dbaron dbaron commented Jun 30, 2022

This set of changes is the result of auditing all specification
Overview.bs other than CSS2 and css-overflow-* for correct handling of
overflow:clip, since many specifications have historically referenced
concepts like "overflow values other than visible".

It is related to #6212, but doesn't actually fix it, because it's really
only a bug in CSS2.

This set of changes is the result of auditing all specification
Overview.bs other than CSS2 and css-overflow-* for correct handling of
overflow:clip, since many specifications have historically referenced
concepts like "overflow values other than visible".

It is related to w3c#6212, but doesn't actually fix it, because it's really
only a bug in CSS2.
@dbaron dbaron added css-ui-3 css-tables-3 Current Work css-overflow-3 Current Work css-backgrounds-3 Current Work css-ui-4 Current Work labels Jun 30, 2022
@dbaron dbaron requested a review from frivoal June 30, 2022 01:11
@dbaron dbaron self-assigned this Jun 30, 2022
Copy link
Contributor

@FremyCompany FremyCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ for what concerns the table spec

@@ -664,6 +663,7 @@ its <a>end</a> line box edge
in the inline progression direction of its block container element ("the block")
that has 'overflow'
other than ''visible''.
<!-- REVIEW: I *think* this should not include ''overflow/clip'' -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

@tabatkins
Copy link
Member

r+ for backgrounds and UI

@fantasai fantasai merged commit 8f5f683 into w3c:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-backgrounds-3 Current Work css-overflow-3 Current Work css-tables-3 Current Work css-ui-3 css-ui-4 Current Work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants