Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resize-observer-1] Include SVG elements that generate CSS layout boxes #4032 #7537

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

w1ndy
Copy link
Contributor

@w1ndy w1ndy commented Jul 26, 2022

This PR incorporates this resolution on the interactions between SVG and ResizeObserver into the spec:

RESOLVED: svg elements generating css layout boxes are included as part of resize observer and resize observer rectangles with a definition of `svg:root, :not(svg|) > svg, svg|foreignObject > svg { /* SVG elements with CSS layout box */}

I wonder if this resolution is still intended to be included in the spec. This PR can be closed if not. Thanks!

@w1ndy
Copy link
Contributor Author

w1ndy commented Jul 26, 2022

Created this PR because the last one (#4150) was closed due to inactivity.
Inviting spec owners @atotic @gregwhitworth , wondering if you have time to review this change?

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to me to correctly incorporate the resolution.

Approving but not merging, as the editors should look at it too.

@gregwhitworth
Copy link
Contributor

gregwhitworth commented Aug 4, 2022

Wow, thank you so much for landing this - I could have sworn I landed the other one; my bad. And thank you @emilio and @svgeesus for the review

@gregwhitworth gregwhitworth merged commit 75abd06 into w3c:main Aug 4, 2022
@emilio
Copy link
Collaborator

emilio commented Aug 4, 2022

@gregwhitworth Thanks for merging!

By the way, in the discussion in #7539 we guessed that you (and @atotic) were no longer interested in editing the ResizeObserver spec, but if by any chance you are please go ahead and re-add yourself as an editor, the more the merrier :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants