[css-device-adapt][css-grid][css-shapes][css-speech] Add range notation #7685
Conversation
| @@ -1593,11 +1593,11 @@ Explicit Track Sizing: the 'grid-template-rows' and 'grid-template-columns' prop | |||
| <dfn><explicit-track-list></dfn> = [ <<line-names>>? <<track-size>> ]+ <<line-names>>? | |||
|
|
|||
| <dfn><line-name-list></dfn> = [ <<line-names>> | <<name-repeat>> ]+ | |||
| <dfn><track-size></dfn> = <<track-breadth>> | minmax( <<inflexible-breadth>> , <<track-breadth>> ) | fit-content( <<length-percentage>> ) | |||
| <dfn><track-size></dfn> = <<track-breadth>> | minmax( <<inflexible-breadth>> , <<track-breadth>> ) | fit-content( <<length-percentage [0,∞]>> ) | |||
There was a problem hiding this comment.
I am not sure about this one because the related paragraph in the spec does not even define a negative value as invalid.
|
This is about grid, not fonts :) |
|
svgeesus marked as non substantive for IPR from ash-nazg. |
svgeesus
changed the title
|
Doh! Do you want me to rename the commit? It is 100% fine with me if the commit is reworked separately. |
|
Its fine, I just re-tagged the PR |
cdoublev
force-pushed
the
range-notation
branch
from
61aa0d5
to
b3c2bc1
Compare
cdoublev
changed the title
| <dfn><track-breadth></dfn> = <<length-percentage>> | <<flex>> | min-content | max-content | auto | ||
| <dfn><inflexible-breadth></dfn> = <<length-percentage>> | min-content | max-content | auto | ||
| <dfn><fixed-breadth></dfn> = <<length-percentage>> | ||
| <dfn><track-breadth></dfn> = <<length-percentage [0,∞]>> | <<flex [0,∞]>> | min-content | max-content | auto |
There was a problem hiding this comment.
0 is unitless because <flex> only accepts fr as unit, therefore it conforms to So long as it's clear, I think the range limitation is fine without units (#7400 (comment)).
| @@ -568,7 +568,7 @@ The 'pause-before' and 'pause-after' properties</h3> | |||
|
|
|||
| <pre class=propdef> | |||
| Name: pause-before, pause-after | |||
| Value: <time> | none | x-weak | weak | medium | strong | x-strong | |||
| Value: <time [0s,∞]> | none | x-weak | weak | medium | strong | x-strong | |||
There was a problem hiding this comment.
0s is used instead of 0 for consistency with existing time range notations, but I think it is not required.
|
Looks good, but in the time since you posted this we've removed the css-device-adapt spec, so now there's a merge conflict. Mind removing that from your PR? r+ to merge after that happens. |
cdoublev
force-pushed
the
range-notation
branch
from
b3c2bc1
to
047f3b9
Compare
Add range notation to some productions used to define a track list.
This change assumes that out of range values are invalid (they are in Chrome/Firefox). This is not explicitly defined in prose, as it is often the case in other specs that use range notation.
EDIT:
After searching for
non-negativein all specs, I added a non-negative range notation for:zoom,min-zoom,max-zoom, in CSS Device Adapt<track-size>,<track-breadth>,<inflexible-breadth>,<fixed-breadth>, in CSS Grid 1-2shape-marginin CSS Shapespause-before,pause-after,rest-before,rest-after,voice-rate, in CSS SpeechI ignored
min-widthandmax-width(descriptors for@viewport) in CSS Device Adapt because there is a note about removing them.