[css-contain-2] Improve definition of contentvisibilityautostatechange event #7740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A [recent commit](w3c@c3d88b2) improved the definition of the event somehow but the link between the `contentvisibilityautostatechanged` event and the `ContentVisibilityAutoStateChanged` is not specified anywhere. This update switches to the usual phrasing used across specs for firing events to make the link between the event type and the interface explicit. Also, Apart from a few exceptions in old specs, events are always named with verbs in the present tense. Accordingly, this update switches the event type to `contentvisibilityautostatechange` instead of `contentvisibilityautostatechanged` and also renames the IDL interfaces. For what it's worth, this guidance does not yet appear in the TAG's API design principles but is considered for inclusion in: w3ctag/design-principles#280 This partially addresses concerns raised in w3c#7603. The spec would still need to to define an `oncontentvisibilityautostatechange` event handler IDL attribute, which could perhaps be done by extending the `GlobalEventHandlers` mixin (to target `HTMLElement`, `MathMLElement` and `SVGElement` all at once) or by working with the WHATWG to integrate the change in HTML directly.
|
+1 This name change went under the radar. And Chrome 108 shipped with |
Apetree100122
approved these changes
Jun 23, 2023
|
(kicking the bots) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit improved the definition of the event somehow but the link between the
contentvisibilityautostatechangedevent and theContentVisibilityAutoStateChangedis not specified anywhere. This update switches to the usual phrasing used across specs for firing events to make the link between the event type and the interface explicit.Also, Apart from a few exceptions in old specs, events are always named with verbs in the present tense. Accordingly, this update switches the event type to
contentvisibilityautostatechangeinstead ofcontentvisibilityautostatechangedand also renames the IDL interfaces. For what it's worth, this guidance does not yet appear in the TAG's API design principles but is considered for inclusion in w3ctag/design-principles#280This partially addresses concerns raised in #7603. The spec would still need to define an
oncontentvisibilityautostatechangeevent handler IDL attribute, which could perhaps be done by extending theGlobalEventHandlersmixin (to targetHTMLElement,MathMLElementandSVGElementall at once) or by working with the WHATWG to integrate the change in HTML directly.