Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-view-transitions-1] Rename domUpdated to updateCallbackDone #8330

Merged
merged 2 commits into from
Jan 19, 2023
Merged

[css-view-transitions-1] Rename domUpdated to updateCallbackDone #8330

merged 2 commits into from
Jan 19, 2023

Conversation

vmpstr
Copy link
Member

@vmpstr vmpstr commented Jan 18, 2023

[css-view-transitions-1] Rename domUpdated to updateCallbackDone

Fixes #8144

@jakearchibald
Copy link
Contributor

jakearchibald commented Jan 18, 2023 •
edited
Loading

Feels like we should also rename the callback as part of this.

Stuff to rename (IMO):

  • updateDOMCallback to updateCallback
  • "DOM update callback" to "update callback"
  • "dom-update-callback-called" to "update-callback-called"
  • "call the DOM update callback" to "call the update callback"

@vmpstr
Copy link
Member Author

vmpstr commented Jan 19, 2023

Done. PTAL

@jakearchibald jakearchibald merged commit b44d8c0 into w3c:main Jan 19, 2023
@vmpstr vmpstr deleted the rename-dom-updated branch January 19, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakearchibald jakearchibald jakearchibald approved these changes

@khushalsagar khushalsagar Awaiting requested review from khushalsagar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[css-view-transitions-1] domUpdated isn't the right term
2 participants
@vmpstr @jakearchibald