Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scroll-animations-1] Add note about horizontal and vertical axis still using logical direction #8667

Merged
merged 4 commits into from
Apr 25, 2023
Merged

[scroll-animations-1] Add note about horizontal and vertical axis still using logical direction #8667

merged 4 commits into from
Apr 25, 2023

Conversation

flackr
Copy link
Contributor

@flackr flackr commented Mar 31, 2023

Fixes #8665

@flackr flackr requested a review from fantasai March 31, 2023 19:00
@ydaniv
Copy link
Contributor

ydaniv commented Mar 31, 2023

For me, in general, this follows expected behavior, so a general SGTM.

@flackr
Copy link
Contributor Author

flackr commented Apr 13, 2023

@fantasai, does this seem reasonable to add?

fantasai
fantasai requested changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • s/may/can/ since we're not granting RFC2119 permission here. :)
  • Move the note up to right after the DL, since it's a user-facing note clarifying the stuff in the DL and the following two paragraphs are rather less interesting to users.
  • This brings up an interesting question about how we measure progress for align-content: end...

flackr and others added 2 commits April 20, 2023 15:45
@flackr @fantasai
Update scroll-animations-1/Overview.bs
91b00d4 
Co-authored-by: fantasai <fantasai.bugs@inkedblade.net>
Add suggestions from fantasai
cadee4b
@flackr
Copy link
Contributor Author

flackr commented Apr 20, 2023

Thanks for the review, I like your edit and moved the note just after the dl as suggested.

@flackr flackr requested a review from fantasai April 21, 2023 17:45
fantasai
fantasai approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wfm, but I think you need to rebase over the latest spec. :/

@flackr flackr merged commit 81b2c13 into w3c:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantasai fantasai fantasai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[scroll-animations-1][css-writing-modes-4] Direction of horizontal / vertical axes
3 participants
@flackr @ydaniv @fantasai