Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scroll-animations-1] Add view-timeline-inset to shorthand #9189

Merged
merged 1 commit into from Aug 18, 2023
Merged

[scroll-animations-1] Add view-timeline-inset to shorthand #9189

merged 1 commit into from Aug 18, 2023

Conversation

andruud
Copy link
Member

@andruud andruud commented Aug 15, 2023

Resolves #8926.

@andruud andruud requested a review from fantasai August 15, 2023 08:25
@andruud
Copy link
Member Author

andruud commented Aug 15, 2023

@fantasai It would be nice to spec this ASAP, since view-timeline recently shipped in Chrome, and it's just going to get harder to change the longer we wait.

Not sure if this is the grammar we want. :-)

flackr
flackr approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@flackr flackr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fantasai fantasai merged commit b29c3e9 into w3c:main Aug 18, 2023
1 check passed
@andruud andruud deleted the view_timeline_inset_shorthand branch August 18, 2023 14:47
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Aug 21, 2023
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 21, 2023
@andruud @chromium-wpt-export-bot
Add view-timeline-inset to view-timeline shorthand
d84ce57 
Per recent spec update [1].

[1] w3c/csswg-drafts#9189

Fixed: 1469850
Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 21, 2023
@andruud @chromium-wpt-export-bot
Add view-timeline-inset to view-timeline shorthand
d83600e 
Per recent spec update [1].

[1] w3c/csswg-drafts#9189

Fixed: 1469850
Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 24, 2023
@andruud @chromium-wpt-export-bot
Add view-timeline-inset to view-timeline shorthand
68fd5d6 
Per recent spec update [1].

[1] w3c/csswg-drafts#9189

Fixed: 1469850
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/yjfaImiMaXE/m/4LKuoM4SAQAJ
Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 24, 2023
@andruud @chromium-wpt-export-bot
Add view-timeline-inset to view-timeline shorthand
4fb038c 
Per recent spec update [1].

[1] w3c/csswg-drafts#9189

Fixed: 1469850
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/yjfaImiMaXE/m/4LKuoM4SAQAJ
Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 25, 2023
@andruud @chromium-wpt-export-bot
Add view-timeline-inset to view-timeline shorthand
2ce5ada 
Per recent spec update [1].

[1] w3c/csswg-drafts#9189

Fixed: 1469850
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/yjfaImiMaXE/m/4LKuoM4SAQAJ
Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4798148
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1188194}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 25, 2023
@andruud @chromium-wpt-export-bot
Add view-timeline-inset to view-timeline shorthand
d7b9c5c 
Per recent spec update [1].

[1] w3c/csswg-drafts#9189

Fixed: 1469850
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/yjfaImiMaXE/m/4LKuoM4SAQAJ
Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4798148
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1188194}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 13, 2023
@andruud @moz-wptsync-bot
Bug 1849565 [wpt PR 41554] - Add view-timeline-inset to view-timeline…
0be38f0 
… shorthand, a=testonly

Automatic update from web-platform-tests
Add view-timeline-inset to view-timeline shorthand

Per recent spec update [1].

[1] w3c/csswg-drafts#9189

Fixed: 1469850
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/yjfaImiMaXE/m/4LKuoM4SAQAJ
Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4798148
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1188194}

--

wpt-commits: d7b9c5c6976717d36fcd54adcaf5e01c82417af8
wpt-pr: 41554
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this pull request Sep 14, 2023
@andruud @moz-wptsync-bot
Bug 1849565 [wpt PR 41554] - Add view-timeline-inset to view-timeline…
ea31e75 
… shorthand, a=testonly

Automatic update from web-platform-tests
Add view-timeline-inset to view-timeline shorthand

Per recent spec update [1].

[1] w3c/csswg-drafts#9189

Fixed: 1469850
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/yjfaImiMaXE/m/4LKuoM4SAQAJ
Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4798148
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1188194}

--

wpt-commits: d7b9c5c6976717d36fcd54adcaf5e01c82417af8
wpt-pr: 41554
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this pull request Dec 11, 2023
@andruud @Lightning00Blade
Add view-timeline-inset to view-timeline shorthand
d578bef 
Per recent spec update [1].

[1] w3c/csswg-drafts#9189

Fixed: 1469850
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/yjfaImiMaXE/m/4LKuoM4SAQAJ
Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4798148
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1188194}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flackr flackr flackr approved these changes

@fantasai fantasai fantasai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[scroll-animations-1] view-timeline-inset as part of view-timeline shorthand?
3 participants
@andruud @flackr @fantasai