-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scroll-animations-1] Add view-timeline-inset to shorthand #9189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@fantasai It would be nice to spec this ASAP, since Not sure if this is the grammar we want. :-) |
flackr
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
fantasai
approved these changes
Aug 18, 2023
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 21, 2023
Per recent spec update [1]. [1] w3c/csswg-drafts#9189 Fixed: 1469850 Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 21, 2023
Per recent spec update [1]. [1] w3c/csswg-drafts#9189 Fixed: 1469850 Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 24, 2023
Per recent spec update [1]. [1] w3c/csswg-drafts#9189 Fixed: 1469850 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/yjfaImiMaXE/m/4LKuoM4SAQAJ Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 24, 2023
Per recent spec update [1]. [1] w3c/csswg-drafts#9189 Fixed: 1469850 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/yjfaImiMaXE/m/4LKuoM4SAQAJ Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 25, 2023
Per recent spec update [1]. [1] w3c/csswg-drafts#9189 Fixed: 1469850 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/yjfaImiMaXE/m/4LKuoM4SAQAJ Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4798148 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1188194}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 25, 2023
Per recent spec update [1]. [1] w3c/csswg-drafts#9189 Fixed: 1469850 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/yjfaImiMaXE/m/4LKuoM4SAQAJ Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4798148 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1188194}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 13, 2023
… shorthand, a=testonly Automatic update from web-platform-tests Add view-timeline-inset to view-timeline shorthand Per recent spec update [1]. [1] w3c/csswg-drafts#9189 Fixed: 1469850 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/yjfaImiMaXE/m/4LKuoM4SAQAJ Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4798148 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1188194} -- wpt-commits: d7b9c5c6976717d36fcd54adcaf5e01c82417af8 wpt-pr: 41554
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Sep 14, 2023
… shorthand, a=testonly Automatic update from web-platform-tests Add view-timeline-inset to view-timeline shorthand Per recent spec update [1]. [1] w3c/csswg-drafts#9189 Fixed: 1469850 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/yjfaImiMaXE/m/4LKuoM4SAQAJ Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4798148 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1188194} -- wpt-commits: d7b9c5c6976717d36fcd54adcaf5e01c82417af8 wpt-pr: 41554
Lightning00Blade
pushed a commit
to Lightning00Blade/wpt
that referenced
this pull request
Dec 11, 2023
Per recent spec update [1]. [1] w3c/csswg-drafts#9189 Fixed: 1469850 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/yjfaImiMaXE/m/4LKuoM4SAQAJ Change-Id: If4011ef0b3dd0bee8737626e41a6c2c5342cb025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4798148 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1188194}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8926.