Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nested div feature and mark as permitted, at risk #237

Closed
nigelmegitt opened this issue Aug 29, 2024 · 0 comments · Fixed by #238
Closed

Add nested div feature and mark as permitted, at risk #237

nigelmegitt opened this issue Aug 29, 2024 · 0 comments · Fixed by #238
Assignees
@nigelmegitt
Labels
CR must-have Must be resolved before going to CR

Comments

@nigelmegitt
Copy link
Contributor 

          This PR looks consistent to me.

The one general comment I would have is that it feels that it is making the spec more complicated for hypothetical forwards compatibility. As discussed in meetings, an alternative could be to make it clear that nested divs are not allowed and if needed in a future version, that version will not be backwards compatible.

I know nested divs is not currently listed as a feature per se but if we continue with that approach into CR, I would like to mark it at risk to allow potentially removing it based on implementation feedback.

Originally posted by @cconcolato in #216 (review)
@nigelmegitt nigelmegitt added the CR must-have Must be resolved before going to CR label Aug 29, 2024
@nigelmegitt nigelmegitt self-assigned this Aug 30, 2024
nigelmegitt added a commit that referenced this issue Aug 30, 2024
@nigelmegitt
Adds permitted feature #scriptEventGrouping
7e88ddf 
Partially closes #237 .
@nigelmegitt nigelmegitt mentioned this issue Aug 30, 2024
Merged
nigelmegitt added a commit that referenced this issue Sep 16, 2024
@nigelmegitt
Adds permitted feature #scriptEventGrouping (#238)
dbcf220 
Closes #237 .

* Adds permitted feature `#scriptEventGrouping`
* Add at-risk features `#scriptEventGrouping` and `#scriptEventMapping`
* Adds link to at-risk feature logged in #239.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nigelmegitt nigelmegitt

Labels
CR must-have Must be resolved before going to CR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds permitted feature #scriptEventGrouping w3c/dapt
1 participant
@nigelmegitt