Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Authorization requirements. #363

Closed
Fak3 opened this issue Jul 29, 2020 · 8 comments
Closed

Clarify Authorization requirements. #363

Fak3 opened this issue Jul 29, 2020 · 8 comments
Assignees
Labels
pr exists There is an open PR to address this issue

Comments

@Fak3
Copy link
Contributor

Fak3 commented Jul 29, 2020

Authorization of operations performed on behalf of the DID subject is defined in several places in the spec and requirements for implementers are unclear.

Section 5.3.2 defines Authorization as "the mechanism used to state how operations are performed (by controller) on behalf of the DID subject. " - it is unclear which operations it is talking about? Does it include DID Document Update operation performed by DID controller? Or does it include assertion of a statement on behalf of the DID subject? (discussed in 5.4.2 assertionMethod). These two exemplified operations have completely different requirements and such vague definition increases confusion about the whole section.

Then it also say that "Each DID method MUST define how authorization and delegation are implemented, including any necessary cryptographic operations." - why core spec delegates the responsibility to the DID method spec, and at the same time define authorization mechanisms as 5.4.2 assertionMethod? What a DID method spec should say about implementation of assertionMethod and other operations (verification relationships) defined in the core spec?

At the end it also suggests methods that a verifiable data registry could implement to support Authorization and delegation. This increases the confusion further - what role the verifiable data registry has in interpreting behavior of 5.4.2 assertionMethod ? Could assertionMethod be delegated too?

It seems that "Authorization" as defined in this section is very vague and confusing. The whole section 5.3.2 should be somehow reworded and probably reorganized to address the relationship between section 5.4 Verification Relationships, the DID method-specific notion of authorizing of DID controller, interpreting controller property of DID Document, requirements for verifiable data registry, and delegation.

@Fak3
Copy link
Contributor Author

Fak3 commented Jul 29, 2020

Rlated: #318 #269 #199 #122

@msporny
Copy link
Member

msporny commented Sep 1, 2020

Agreed, we need to rewrite how Authorization is described in the spec and the Editors will need to do that in a rewrite.

@msporny
Copy link
Member

msporny commented Sep 22, 2020

Still waiting on a PR.

@msporny msporny added pre-cr-p2 ready for pr Issue is ready for a PR labels Nov 3, 2020
@rhiaro
Copy link
Member

rhiaro commented Nov 16, 2020

The Authorization section has now gone, and the whole Core Properties section has been reorganised and tidied up since this issue would raised. @Fak3 could you review Verification Methods and Verification Relationships to see if the latest versions goes some way towards answering your questions?

@OR13
Copy link
Contributor

OR13 commented Dec 8, 2020

recommend closing, since the spec has drifted

@msporny msporny removed the ready for pr Issue is ready for a PR label Dec 8, 2020
@msporny
Copy link
Member

msporny commented Jan 3, 2021

PR #525 has been raised to address this issue. This issue will be closed once PR #525 is merged. @Fak3, please let us know if this addresses the concerns you raised above.

@msporny msporny added the pr exists There is an open PR to address this issue label Jan 3, 2021
@Fak3
Copy link
Contributor Author

Fak3 commented Jan 4, 2021

Thank you. PR looks good to me

@msporny
Copy link
Member

msporny commented Jan 12, 2021

PR #525 has been merged, closing.

@msporny msporny closed this as completed Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr exists There is an open PR to address this issue
Projects
None yet
Development

No branches or pull requests

4 participants