-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare that order is unimportant in all "ordered sets" #656
Comments
I would certainly prefer this than adding that extra note everywhere in the document (which would make reading fairly difficult). I am not convinced it is necessary, though. |
Hmm, depends on the sort of interop you're talking about... and that text is really speaking to "code running on different browsers when iterating over an Object over the years have tried to make sure they preserve insertion order"... which is very different than "ordering of the information model" (e.g., RDF Dataset Canonicalization). I don't think we need to loudly declare this in the specification more than once. We should loudly declare it once, though. We're just saying -- you can't depend on order, so unless you have some ordering mechanism that you're sure works (like RDF Dataset Normalization)... don't assume that order is preserved. |
Changes: To: |
I want to make a small to the text within that box ... but it's further away from the single-word change you made than github will allow me to make a suggestion on. I'd change --
-- to --
To be clear, I've added And I still think that all the links to |
This (#656) remains that issue. |
This was added to the spec a bit ago... forget which PR, but it's in there now along with more changes, to drive your point home @TallTed, in 218f6ff. I also changed "ordered set" -> "set" to not convey that order is important for sets and cross-checked the entire specification to make sure we don't depend on set ordering anywhere (we don't). I'm hesitant to belabor the point more in the spec. I'm marking this pending close, folks that don't feel like we have closure on this yet, feel free to object to closing. |
I'll hope the sum of changes to date is sufficient. We'll find out! I'm OK with closing this one. |
I do not think the single note
<p class="note" title="Ordering of values">
about this is sufficient.I think adding such an inline declaration every time is important, because the INFRA doc to which every instance of "ordered set" links includes notes of --
-- and --
-- which both loudly hint that order is important for interop.
Could be as simple as adding
(although the order of elements is unimportant within DID Core, DID methods are free to specify an ordering algorithm that must be used for interop within that DID method)
or similar to allproperty MUST be ... an <a data-cite="INFRA#ordered-set">ordered set</a> ...
statements.This would not be necessary if all the current links to
"INFRA#ordered-set"
instead went to our own discussion thereof, with the "order doesn't matter" declaration, and then linked out to the INFRA spec.The text was updated successfully, but these errors were encountered: