-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rotation and recovery sections from previous PR #569
Conversation
index.html
Outdated
time the compromised verification method was registered, to the time it was revoked. | ||
</p> | ||
|
||
<p class="note"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this note in an attempt to align how we describe revocation with how the impact of the revocation of the solar winds code signing certificate is described.
@dlongley you left comments but did not request changes previously, if you would not mind either requesting changes or approving the PR, that would help me make sure it meets your needs. |
@csuwildcat @selfissued anyone from Microsoft want to add some comments about revocation and why its valuable to did core? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR essentially ignores all the feedback I gave on the previous PR. It is just as unacceptable to me, and for exactly the same reasons, as the previous PR where I commented in detail and provided alternate verbiage.
index.html
Outdated
<p class="advisement"> | ||
Cryptographic verifications associated with revoked verification | ||
methods should be considered invalid regardless of when revocation | ||
occurs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhh1128, could you make a suggestion here? I presume you'd like this language tweaked to be more clear that verifiers may decide to continue to honor proofs previously made and verified in the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, in essence, I think he wants to allow verifiers to ignore that keys have been revoked... which is their prerogative.
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
I had a good chat with @dhh1128 on this, decision was to split out "revocation" into a separate PR, I will also try to better address his concerns on that section in isolation from the other changes, should make it easier to review. |
I am removing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am content with this PR with the minor proviso that I would prefer to have two words deleted, as I noted separately.
What does "previous PR" mean? Please reference specific PR that is being replaced by this one. |
Also, please resolve merge conflicts, so that further review and suggestions here aren't moot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small suggestions.
Co-authored-by: Brent Zundel <brent.zundel@gmail.com>
I believe I have implemented all requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, merging them, then merging this PR.
@OR13 please pay particular attention to one MUST that I removed -- we can't put normative statements in this section, and in addition, I'd suggest that the normative statement should be tested by this WG anyway.
Co-authored-by: Josh Mandel <jmandel@alum.mit.edu>
Editorial, multiple reviews, changes requested and made, no objections, merging. |
Previous PR was corrupted with merge conflicts, this was an easier way for me to get a clean change-set...
All feedback as existing on the previous PR has been implemented (but not accepted)
#548
Specifically @dhh1128 please request any changes on this PR that I failed to address.
Preview | Diff