Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add did:vaa: method #98

Merged
merged 2 commits into from
Aug 6, 2020
Merged

add did:vaa: method #98

merged 2 commits into from
Aug 6, 2020

Conversation

caict-develop-zhangbo
Copy link
Contributor

@caict-develop-zhangbo caict-develop-zhangbo commented Jul 30, 2020

@caict-develop-zhangbo caict-develop-zhangbo changed the title add dod:vaa: method add did:vaa: method Jul 30, 2020
Copy link
Contributor

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to watch for did core spec changes related to "metadata", this is one of the few did methods I have seen that includes "updated', "created" and "revoked" timestamps in the did document.

Privacy and Security Considerations section could use a little more clarity, for example:

"DID documents use signature technology to prevent malicious error correction."

I don't see signatures on the HTTP based operations, or on the documents themselves.

@OR13
Copy link
Contributor

OR13 commented Aug 3, 2020

@caict-develop-zhangbo putting this on your radar: w3c/did-core#174 (comment)

@caict-develop-zhangbo
Copy link
Contributor Author

caict-develop-zhangbo commented Aug 5, 2020

@caict-develop-zhangbo putting this on your radar: w3c/did-core#174 (comment)

You may want to watch for did core spec changes related to "metadata", this is one of the few did methods I have seen that includes "updated', "created" and "revoked" timestamps in the did document.

Privacy and Security Considerations section could use a little more clarity, for example:

"DID documents use signature technology to prevent malicious error correction."

I don't see signatures on the HTTP based operations, or on the documents themselves.

Thanks for review, I've adjusted the "updated', "created" and "revoked" timestamps and added signatures instructions

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meets minimum requirements for provisional registration.

@msporny msporny merged commit 30f6d42 into w3c:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants