Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acknowledge an expansion of scope #55

Merged
merged 5 commits into from
Nov 2, 2021
Merged

acknowledge an expansion of scope #55

merged 5 commits into from
Nov 2, 2021

Conversation

rxgrant
Copy link
Contributor

@rxgrant rxgrant commented Sep 20, 2021 •
edited by pr-preview bot
Loading

see rubric issue #54.

Preview | Diff

@rxgrant rxgrant mentioned this pull request Sep 20, 2021
Open
jandrieu
jandrieu reviewed Sep 20, 2021
View reviewed changes
index.html Outdated Show resolved Hide resolved
jandrieu
jandrieu reviewed Sep 20, 2021
View reviewed changes
index.html Outdated Show resolved Hide resolved
jandrieu
jandrieu requested changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@jandrieu jandrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is definitely out of date.

I like the general gist, but it could use some clean up on the opinions language.

rxgrant and others added 2 commits September 21, 2021 14:14
rxgrant
rxgrant commented Nov 2, 2021
View reviewed changes
index.html Outdated Show resolved Hide resolved
rxgrant
rxgrant commented Nov 2, 2021
View reviewed changes
index.html Outdated Show resolved Hide resolved
@jandrieu
Copy link
Contributor

jandrieu commented Nov 2, 2021

Looks good. Healthy discussion and easy improvement.

@jandrieu jandrieu merged commit 065a207 into w3c:main Nov 2, 2021
@rxgrant rxgrant deleted the rxgrant-20210920 branch November 2, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandrieu jandrieu jandrieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rxgrant @jandrieu