Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Issue 32 #48

Merged
merged 9 commits into from
Feb 7, 2024
Merged

Address Issue 32 #48

merged 9 commits into from
Feb 7, 2024

Conversation

nicholascar
Copy link
Contributor

@nicholascar nicholascar commented Aug 23, 2023

Closes #32


Preview | Diff

@nicholascar nicholascar marked this pull request as ready for review September 6, 2023 11:30
@nicholascar nicholascar changed the title Issue 32 Address Issue 32 Sep 6, 2023
Copy link
Contributor

@larsgsvensson larsgsvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #32 it says that we should "create a namespaces table in the document preamble". If interpret the html correctly, this table is still missing (or am I missing something)?

@nicholascar
Copy link
Contributor Author

You are correct Lars, and that's why I created this as a Draft PR - that it still not done. But then I forgot about that bit in the meeting just now and converted the PR from Draft to ready. I will update this PR with that change shortly.

@larsgsvensson
Copy link
Contributor

You are correct Lars, and that's why I created this as a Draft PR - that it still not done. But then I forgot about that bit in the meeting just now and converted the PR from Draft to ready. I will update this PR with that change shortly.

OK, thx. Looking forward to that.

@nicholascar
Copy link
Contributor Author

Namespaces table added.

I tidied up Turtle to use PREFIX consistently, not some PREFIX and some @prefix.

Replaces one different use of altr in an example.

Copy link
Contributor

@YoucTagh YoucTagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example 17 uses rdfs:Resource while the rest of the document correctly uses rdf:Resource.

I noticed that CODE LISTING 3 is overflowing. Maybe because it is missing a css style class.

@nicholascar
Copy link
Contributor Author

All rdf:Resource mistakes have been converted to correct rdfs:Resource

Copy link
Contributor

@YoucTagh YoucTagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In index.html line 1523 rdfs:Resource is used, while in the rest rdfs:Resources is the one used.

Copy link
Contributor

@rob-metalinkage rob-metalinkage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of changes here - would be good to document what and why - using a formatting tool to normalise is obviously a good thing. it looks like only one substantive fix ?

@nicholascar
Copy link
Contributor Author

I've fixed the mistaken plural rdfs:Resources and updated it to rdfs:Resource.

I've merged in all the other elements here too, such as Yousuf's editor details.

Copy link
Contributor

@YoucTagh YoucTagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. Thanks!

@nicholascar nicholascar merged commit 54778f0 into w3c:gh-pages Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URIs in figure 2 could be turned into links to increase clarity
4 participants