-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address Issue 32 #48
Address Issue 32 #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #32 it says that we should "create a namespaces table in the document preamble". If interpret the html correctly, this table is still missing (or am I missing something)?
You are correct Lars, and that's why I created this as a Draft PR - that it still not done. But then I forgot about that bit in the meeting just now and converted the PR from Draft to ready. I will update this PR with that change shortly. |
OK, thx. Looking forward to that. |
Namespaces table added. I tidied up Turtle to use Replaces one different use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example 17 uses rdfs:Resource
while the rest of the document correctly uses rdf:Resource
.
I noticed that CODE LISTING 3
is overflowing. Maybe because it is missing a css style class.
All |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In index.html
line 1523 rdfs:Resource
is used, while in the rest rdfs:Resources
is the one used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot of changes here - would be good to document what and why - using a formatting tool to normalise is obviously a good thing. it looks like only one substantive fix ?
I've fixed the mistaken plural I've merged in all the other elements here too, such as Yousuf's editor details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me. Thanks!
Closes #32
Preview | Diff