-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonise property labels #534
Comments
I have harmonised property names across all HTML, RDF & image resources, including examples in a branch. I have prepared this pull request: #532 showing the changes. |
I doubt that there is consensus that this is considered a "best practice". |
I see some pros and cons for this proposal: pros:
cons:
Given the work involved has been done (the biggest issue) and a PR generated, and Nick is an implementer, and I will also implement in a different context and have been hanging off waiting for expected name changes from FPWD feedback.... I'm inclined to support the proposal as a marginal improvement in readability - that won't delay us getting to a FPWD. So I guess it comes down now to the group consensus on property naming styles.. It doesnt affect the readiness of the FPWG - we simply choose version 1 or 2.. We have two choices:
|
My recommendation on this is to get labels harmonized and discuss prefered convention later. After all, this issue is only about getting labels harmonized :-) In any case transition to FPWD cannot result in enshrining anything like this. |
Due for closing as the issue has been resolved in the now merged #532 |
Getting the labels harmonised is important and except for what I reported in #555 and proposed fix in #556, it should be ok in the ontology. In terms of the names themselves, I would have preferred the shorter names (e.g. |
Actually, the document still has some misalignments with respect to the ontology: dxwg/profilesont/profilesont.ttl Line 82 in 78a2a3d
|
Thanks @agbeltran, I have update the label "profile of" -> "is profile of". It's perhaps not thrilling styalistically to have these longer property names but it is consistent... |
Labels harmonised in document as per this date |
Some of the ontology's properties start with a has-, like
hasRole
,hasResource
but not all do, liketoken
and the inverse propertieshasProfile
andprofileOf
don't follow the same naming pattern. Also, in some places, like the example diagrams and the RDF ontology, property names are inconsistent.Best practice for property naming, as exemplified by the SSN ontology, is to use has- and is- across the board for present tense properties (as PROV uses was-, had- for past tense things) so the inverse of
hasProfile
would beisProfileOf
, not justisProfile
, as it currently is, andtoken
would behasToken
.Renaming properties would make no difference to the ontology functioning but would better indicate the purpose and direction of properties (
:Profile-X prof:hasToken :Token-Y
is thought to be more intuitive according to SSN & TIME etc.If a renaming is to be made, best it is done before use (ideally before FPWD).
The text was updated successfully, but these errors were encountered: