Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfishined renaming of properties in profiles ontology causing loading error #555

Closed
agbeltran opened this issue Nov 13, 2018 · 4 comments
Closed
Labels
due for closing Issue that is going to be closed if there are no objection within 6 days profiles-vocabulary For discussion of profile description vocabulary

Comments

@agbeltran
Copy link
Member

In the commit 6477e3f related to #534, one property name remained unchanged. This line:

owl:onProperty :profileOf ;

has profileOf instead of the newly defined isProfileOf causing errors when loading the ontology in Protege.

Also, several of comment lines with the terms URIs have the old names.

This was referenced Nov 13, 2018
@agbeltran agbeltran added the profiles-vocabulary For discussion of profile description vocabulary label Nov 13, 2018
nicholascar pushed a commit that referenced this issue Nov 13, 2018
@kcoyle
Copy link
Contributor

kcoyle commented Aug 19, 2019

@agbeltran will need to say whether her issue has been resolved. Re-opening.

@kcoyle kcoyle reopened this Aug 19, 2019
@nicholascar
Copy link
Contributor

nicholascar commented Aug 29, 2019

It is clear that the issue is resolved: the single property unchanged at :profileOf was changed to :isProfileOf... 9 months ago!

@nicholascar nicholascar pinned this issue Aug 29, 2019
@nicholascar nicholascar unpinned this issue Aug 29, 2019
@nicholascar nicholascar added the due for closing Issue that is going to be closed if there are no objection within 6 days label Aug 29, 2019
@nicholascar
Copy link
Contributor

Closing after listing in plenary 2019-09-03 + 3-day wait period.

@kcoyle
Copy link
Contributor

kcoyle commented Sep 8, 2019

@nicholascar the closing resolution appears to be that the loading error was fixed in pull request #556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
due for closing Issue that is going to be closed if there are no objection within 6 days profiles-vocabulary For discussion of profile description vocabulary
Projects
None yet
Development

No branches or pull requests

3 participants