-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial fixes for Prof 3 pwd candidate prior to introducing final substantive change proposals. #1074
Conversation
# Conflicts: # profilesont/index.html
…es for better version tracking
I'm not sure why 521, 507, 802, 453, 795 are not mentioned in the doc anymore. As long as they remain open on github while they're under discussion, that's fine, but this makes it less clear, what's the rationale for having issues referenced or not in the document. |
In 6.8 Repetition in "Constraint Languages are frequently used in profile profile definitions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I've reviewed what I could review. All comments that I think could (some should) be addressed are now above!
I forgot to say - impressive work, @nicholascar ! |
There seems to be content here that is not resolved in issues. For example, @aisaac are you satisfied with the resolution of "prof:isTransitiveProfileOf needs more convincing case and/or example #643"? Also, we have: "Improve defintion of prof:isTransitiveProfileOf #1071", "Suggested updates to definition of PROF constructs #1061" not to mention about 80 other open issues. What is being proposed for all of the open issues that are not considered "at risk"? |
@kcoyle I think it is ok to have a PR doing things not in issues, and not tackling all open issues. There could be another later PWD candidate to address the open issues, for sure. Maybe it's already in preparation. This PR is already big; I think in general they should be more granular. |
Regarding the definition of profiles (for this and for the conneg document), the approved language is:
While it probably makes sense to say in the definitions area that the word "profile" will be used in the document to mean what is defined as "data profile", the group did vote to define the term as "data profile." |
@aisaac You may have missed the information on the deadline. The date and time of tomorrow's meeting is the final deadline for a CR-ready version of PROF and of conneg. There will not be additional "PRs" except in support of a Working Group note. That is why I am questioning the disposition of open issues. I'm trying to understand whether this version is considered final or if the editors are planning to continue the work as a note. |
The PR is not addressing the definitions - thats a substantive change that needs to be isolated to a separate PR. I think the problem is in the title - i'll rename it.. |
Thanks for the clarification @rob-metalinkage . @kcoyle this was indeed my approach when looking at this PR. Not requiring that it does everything. In fact I implicitly said earlier to @nicholascar that it would be great if we would stop piling things in here, because otherwise I can't review them :-) |
…ofile" definition exactly as per #963
@aisaac I've addressed 4 of your comments requesting changes (see commits above linking to comment IDs) and regarding #1074 (comment) (Issues removed):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK @nicholascar thanks for the explanation and the last edits which indeed fix the typos that I had found and revert the definition to the official one.
And I agree with removing the reference to the couple of issues you flag as "(near-)duplicates". Even if they are still open, the document makes reference to "nearby" issues. It would be confusing to point the reader to all the issues in our web - it's already quite difficult for ourselves...
See the rendered HTML: https://raw.githack.com/w3c/dxwg/prof-3PWD-candidate/prof/