Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision to the versioning section #1257

Merged
merged 16 commits into from
Oct 5, 2020
Merged

Conversation

andrea-perego
Copy link
Contributor

@andrea-perego andrea-perego commented Sep 22, 2020

dcat/index.html Outdated Show resolved Hide resolved
dcat/index.html Outdated Show resolved Hide resolved
@riccardoAlbertoni
Copy link
Contributor

Many thanks for preparing this, @andrea-perego .
I think you have captured the discussion we had well, and you also provided a good overview of alternatives.
I have just added a couple of things. Please see my suggestions above.

After we have solved my revisions, I think we will be ready to change the pull's status, making it ready for other editors' review.

BTW, this pull relates with #89 #1238 #91 #92

andrea-perego and others added 4 commits September 22, 2020 18:51
Co-authored-by: Riccardo Albertoni <albertoni@ge.imati.cnr.it>
Co-authored-by: Riccardo Albertoni <albertoni@ge.imati.cnr.it>
Co-authored-by: Riccardo Albertoni <albertoni@ge.imati.cnr.it>
Co-authored-by: Riccardo Albertoni <albertoni@ge.imati.cnr.it>
@andrea-perego
Copy link
Contributor Author

Many thanks for preparing this, @andrea-perego .
I think you have captured the discussion we had well, and you also provided a good overview of alternatives.
I have just added a couple of things. Please see my suggestions above.

Thanks, @riccardoAlbertoni . Just accepted your changes.

@pwin pwin self-requested a review September 23, 2020 11:53
@andrea-perego
Copy link
Contributor Author

andrea-perego commented Sep 23, 2020

@riccardoAlbertoni , I tried to add the issue summary section and issue #1258 . The issue box seems to show up correctly:

https://raw.githack.com/w3c/dxwg/dcat-versioning/dcat/#issue-container-number-1258

However, the issue summary section seems to have some rendering issues. You can see it right before the introduction:

https://raw.githack.com/w3c/dxwg/dcat-versioning/dcat/#introduction

This may be a bug in the new ReSpec library. I'll raise an issue in the ReSpec repo.

@andrea-perego
Copy link
Contributor Author

Added links to relevant issues (as decided during the DCAT subgroup call).

Please have a check. Then, I think we can mark this PR as ready for review.

@riccardoAlbertoni
Copy link
Contributor

@andrea-perego: I've checked this, and I think we can have this PR as ready for review. Many thanks.

@andrea-perego
Copy link
Contributor Author

@andrea-perego: I've checked this, and I think we can have this PR as ready for review. Many thanks.

Thanks, @riccardoAlbertoni .

@andrea-perego andrea-perego marked this pull request as ready for review October 1, 2020 16:22
@riccardoAlbertoni riccardoAlbertoni merged commit 80a7b1c into gh-pages Oct 5, 2020
@andrea-perego andrea-perego deleted the dcat-versioning branch October 5, 2020 11:23
@andrea-perego
Copy link
Contributor Author

Just for our records, the issue I reported in #1257 (comment) has been fixed - see https://github.com/w3c/respec/pull/3152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants