Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distribution digest #1323

Merged
merged 11 commits into from
Mar 22, 2021
Merged

Add distribution digest #1323

merged 11 commits into from
Mar 22, 2021

Conversation

andrea-perego
Copy link
Contributor

Relevant issue: #1287

Summary of changes:

  • Add property spdx:checksum to dcat:Distribution
  • Add class spdx:Checksum (range of property spdx:checksum) and related properties spdx:algorithm and spdx:checksumValue
  • Add SPDX to the namespace table
  • Update changelog accordingly

Preview of the newly added sections:

Diff: https://services.w3.org/htmldiff?doc1=https%3A%2F%2Fw3c.github.io%2Fdxwg%2Fdcat%2F&doc2=https%3A%2F%2Fraw.githack.com%2Fw3c%2Fdxwg%2Fdcat-distribution-digest%2Fdcat%2Findex.html

dcat/config.js Show resolved Hide resolved
dcat/index.html Outdated Show resolved Hide resolved
@andrea-perego andrea-perego marked this pull request as ready for review March 17, 2021 11:12
@agbeltran
Copy link
Member

thanks for addressing my previous comments @andrea-perego - I suggest we add a reference to https://spdx.dev in addition to the vocabulary (as it provides a lot more information about the vocabulary and its governance)

@riannella
Copy link

@agbeltran I agree that the definition provided by SPDX is not clear (authenticity V integrity) - but since we are reusing their property then we have to use the same definition. Perhaps we should make this feedback available to the SPDX team?

@agbeltran
Copy link
Member

@riannella I agree we should feed this back to the SPDX community, but the changes we are making in the definition are more clarifications than changing the essense of the property, so I don't think we need to copy the definition verbatim (and we should say that the definition is based on SPDX) - what do others think?

@riannella
Copy link

@riannella I agree we should feed this back to the SPDX community, but the changes we are making in the definition are more clarifications than changing the essense of the property, so I don't think we need to copy the definition verbatim (and we should say that the definition is based on SPDX) - what do others think?

Done: spdx/spdx-spec#500

I am happy for us to adopt this update now.

@agbeltran
Copy link
Member

@riannella I agree we should feed this back to the SPDX community, but the changes we are making in the definition are more clarifications than changing the essense of the property, so I don't think we need to copy the definition verbatim (and we should say that the definition is based on SPDX) - what do others think?

Done: spdx/spdx-spec#500

I am happy for us to adopt this update now.

that's brilliant - thanks @riannella

@andrea-perego
Copy link
Contributor Author

thanks for addressing my previous comments @andrea-perego - I suggest we add a reference to https://spdx.dev in addition to the vocabulary (as it provides a lot more information about the vocabulary and its governance)

Thanks, @agbeltran . Could you please suggest the actual revision to be made?

BTW, I just saw that now https://spdx.org/ (pointing to the old Web site) redirects to https://spdx.dev/ (the new one), so probably this revision is no longer needed.

@andrea-perego
Copy link
Contributor Author

@riannella I agree we should feed this back to the SPDX community, but the changes we are making in the definition are more clarifications than changing the essense of the property, so I don't think we need to copy the definition verbatim (and we should say that the definition is based on SPDX) - what do others think?

Done: spdx/spdx-spec#500
I am happy for us to adopt this update now.

that's brilliant - thanks @riannella

Thanks, @agbeltran & @riannella .

Revision implemented via commit 8c64f98

@andrea-perego
Copy link
Contributor Author

thanks for addressing my previous comments @andrea-perego - I suggest we add a reference to https://spdx.dev in addition to the vocabulary (as it provides a lot more information about the vocabulary and its governance)

Thanks, @agbeltran . Could you please suggest the actual revision to be made?

BTW, I just saw that now https://spdx.org/ (pointing to the old Web site) redirects to https://spdx.dev/ (the new one), so probably this revision is no longer needed.

@agbeltran , I'm now going to merge this PR, as this is just an editorial revision that can be implemented in a new PR.

@andrea-perego andrea-perego merged commit a24a8e2 into gh-pages Mar 22, 2021
@andrea-perego andrea-perego deleted the dcat-distribution-digest branch March 22, 2021 22:15
@andrea-perego andrea-perego linked an issue Mar 23, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Digest for DCAT distributions
4 participants