-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EditContext: should editContext be on Element? #18
Comments
HTMLElement makes perfect sense. Thanks for the comment! we'll revise the spec in the next version. |
aarongable
referenced
this issue
in chromium/chromium
Mar 22, 2022
This CL exposes EditContext through HTMLElement (same scope as contentEditable) instead of Element to address w3c editing issue #369 [1]. The main logic remains in Element since it's calling Element's private functions such as EnsureElementRareData() and InlineStyleChanged(). [1] https://github.com/w3c/editing/issues/369 Bug: 999184 Change-Id: Iccb275c4959148432425af1db37d8f64eb4fdecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3531533 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Alex Keng <shihken@microsoft.com> Cr-Commit-Position: refs/heads/main@{#983707}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Perhaps
contenteditable
's scope is a more reasonable starting point? Especially given the list of "supported elements" it doesn't seem like this needs to be onElement
, butHTMLElement
would work just as well.The text was updated successfully, but these errors were encountered: