Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditContext: should editContext be on Element? #18

Closed
annevk opened this issue Dec 6, 2021 · 1 comment
Closed

EditContext: should editContext be on Element? #18

annevk opened this issue Dec 6, 2021 · 1 comment

Comments

@annevk
Copy link
Member

annevk commented Dec 6, 2021

Perhaps contenteditable's scope is a more reasonable starting point? Especially given the list of "supported elements" it doesn't seem like this needs to be on Element, but HTMLElement would work just as well.

@alexkeng
Copy link
Contributor

alexkeng commented Dec 10, 2021

HTMLElement makes perfect sense. Thanks for the comment! we'll revise the spec in the next version.

@alexkeng alexkeng reopened this Dec 10, 2021
aarongable referenced this issue in chromium/chromium Mar 22, 2022
This CL exposes EditContext through HTMLElement (same scope
as contentEditable) instead of Element to address w3c editing
issue #369 [1]. The main logic remains in Element
since it's calling Element's private functions such as
EnsureElementRareData() and InlineStyleChanged().

[1] https://github.com/w3c/editing/issues/369

Bug: 999184
Change-Id: Iccb275c4959148432425af1db37d8f64eb4fdecc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3531533
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Alex Keng <shihken@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#983707}
@travisleithead travisleithead transferred this issue from w3c/editing Apr 21, 2022
alexkeng added a commit that referenced this issue Mar 14, 2023
add more details to the spec and address issue #16 #18 #24 #29 #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants