-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec defines 'double' in a way that collides with WebIDL #89
Comments
@snianu or @alexkeng do you know where "double" would actually be needed? In Chromium at least it doesn't look like "double" is a possible IME underline style (link): enum class UnderlineStyle {
kNone,
kSolid,
kDot,
kDash,
kSquiggle,
}; I'm wondering if this can just be removed...but maybe you remember some context for why it's an option in the spec? Is it used with IMEs in other browsers? |
I spoke with @snianu about this today. |
The Web Editing Working Group just discussed The full IRC log of that discussion<dandclark> topic: Spec defines 'double' in a way that collides with WebIDL #89<dandclark> github: https://github.com//issues/89 <smaug> dandclark: double isn't actually hooked up with anything, so there is no known use for it <smaug> dandclark: if it is not used, we should just remove it <smaug> johanneswilm: is use cases appear in the future, we can add more types <smaug> johanneswilm: anyone fine removing it <smaug> yes <smaug> https://github.com//issues/88 <smaug> topic https://github.com//issues/88 <smaug> dandclark: the spec doesn't handle the bounds of the selection start/end <smaug> dandclark: should we clamp or throw ? <smaug> smaug: Range does throw <smaug> johanneswilm: throwing error could make it easier to find issues in js code <smaug> johanneswilm: it would be good to give a way to find js issues <smaug> smaug: are there APIs which do clamp? <smaug> dandclark: maybe the right answer is to throw <smaug> dandclark: hopefully we can find that no one relies on the current behavior <smaug> dandclark: and also if we can find counter example where clamping does happen <smaug> smaug: by default we should try to follow existing old APIs <smaug> dandclark: I'll investigate |
The `double` UnderlineStyle was added in anticipation of a planned Windows feature that never came to be. There are no other known uses, so remove it. Closes #89
Maybe use a different term?
I'm seeing this Bikeshed error on an unrelated document:
The text was updated successfully, but these errors were encountered: