-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link element order and priority tests #172
Conversation
@iherman Ahh, okay, I see. So for
The rest of the file would be unchanged so I won't paste it here. Similarly, for
|
Thanks a lot, @m22chan ! I have updated all ONIX files accordingly. If otherwise you think the tests are o.k., can you approve the PR? Thanks again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
The PR adds two tests to the
link
element in §5.3 of the reading system spec, for the following statement:Fix #171
@m22chan, I reused an older test of yours (I have added a small sentence into the description, b.t.w.) with minimal changes, so I kept your name. I look at the onix file would be helpful to be sure that the title I added is o.k.