add test for OCF different compression #188
Conversation
Add test for #185 Used bzip2 for compression zip -rX -Z bzip2 ../ocf-zip-comp.epub mimetype META-INF EPUB
|
Will send PR to epub-specs after this one got merged |
| <dc:creator>Zheng Xu</dc:creator> | ||
| <dc:date>2022-07-30</dc:date> | ||
| <dc:description>MUST treat any OCF ZIP container that uses compression techniques other than Deflate as in error.</dc:description> | ||
| <dc:identifier id="pub-id">ocf-zip-comp</dc:identifier> |
There was a problem hiding this comment.
Minor knit: can you align the entry to the left with the rest of the items? Thx.
| <title>OCF ZIP container uses compression techniques other than Deflate</title> | ||
| </head> | ||
| <body> | ||
| <p>Test passes if reading system raises error when loading this epub file and this page of the book can not be accessed.</p> |
There was a problem hiding this comment.
(I am being overly picky here...).
Very strictly speaking, we do not define what the RS' error behaviour is. It is conceivable that a RS, whilst reporting an error, makes an attempt to display the content nevertheless. This should be acceptable (while making it clear that this is an erroneous EPUB).
| <p>Test passes if reading system raises error when loading this epub file and this page of the book can not be accessed.</p> | |
| <p>Test passes if reading system raises error when loading this epub file.</p> |
Note that the same change should be made on the ocf-zip-mult test, too. My apologies not to have realized that before.
There was a problem hiding this comment.
no problem. Thanks, I will make changes to both.
forgot attaching epub file
|
@Jeffxz as far as I see, this is now done and can be merged, correct? If true, I will merge it and you should create a PR for the references in the spec. Thanks! |
|
thanks @iherman. ready to merge. I am going to send PR to spec now. |
add test reference for w3c/epub-tests#185 w3c/epub-tests#188
Add test for #185
Used bzip2 for compression
Extracted folder was tested by epubcheck. Zipped file raised compression error via epub check