Add report for EasyReader covering MO tests #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As there isn't a diff or preview, the media overlay test reporting begins at line 59 of the file: https://github.com/w3c/epub-tests/pull/278/files#diff-a55b9edd5fbec56da548b8e9bdd894676312ee08e9ab48764d533215798acf65R59 |
|
I am a bit worried about submitting a test report for which most cells will be a '?' (or an empty cell, if #272 is accepted). It will look a bit strange... I would think we should merge this as a last resort. I have just received, separately, a colibrio report that seems to cover most of the MO tests, so the whole issue may be moot... (I will submit the separate PR with that in a moment.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't use the test files for verifying support as EasyReader is more particular about how media overlay publications are constructed (all text must be synchronized, etc.), but I was able to mimic all the tests with a separate publication.
Ideally, this report should be more comprehensive, but given the primary need for verifying media overlays I'm starting only with that section. If time permits, I can try and fill in some more general support details.