feat: improve checking of data URLs #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the following checks: - `RSC-029`(new): check that `data` URLs are not used when they would result in a top-level browsing context - check `data` URLs for foreign resource restrictions (fallbacks) An OPFItem instance can now represent a manifest item defined as a data URL. A `hasDataURL()` method will tell if this is the case. Fix #1238, fix #1239.
mattgarrish
approved these changes
Dec 2, 2022
Base automatically changed from
fix/regression-message-location
to
release/v5.0.0
December 6, 2022 14:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the following checks:
RSC-029(new): check thatdataURLs are not used when they would result in a top-level browsing contextdataURLs for foreign resource restrictions (fallbacks)An OPFItem instance can now represent a manifest item defined as a data URL. A
hasDataURL()method will tell if this is the case.Fix #1238, fix #1239.
Note: this does not implement the newest resolution that data URLs are not allowed for publication resources