-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[motion-1] The computed value of offset-path: path(' ') #392
Comments
Blink treats I don't see value in maintaining different computed style states for these. The spec could state that |
Great. Thanks. This is also for |
It seems really odd to serialize it as |
It is, that is why in the example it sets the specified value, while |
But they're not the same, right? |
Per SVG2 spec, the EBNF allows the path data string to be empty. An empty path data string disables rendering of the path. Therefore, we should make path('') a valid path string. The related spec issue: w3c/fxtf-drafts#392. Now we serialize `path("")` as `path("")` for offset-path and clip-path. Differential Revision: https://phabricator.services.mozilla.com/D60771 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1609786 gecko-commit: 1ef31cd775e69a42d7c9b67b5ac86f65ef808b25 gecko-integration-branch: autoland gecko-reviewers: emilio
Per SVG2 spec, the EBNF allows the path data string to be empty. An empty path data string disables rendering of the path. Therefore, we should make path('') a valid path string. The related spec issue: w3c/fxtf-drafts#392. Now we serialize `path("")` as `path("")` for offset-path and clip-path. Differential Revision: https://phabricator.services.mozilla.com/D60771
Per SVG2 spec, the EBNF allows the path data string to be empty. An empty path data string disables rendering of the path. Therefore, we should make path('') a valid path string. The related spec issue: w3c/fxtf-drafts#392. Now we serialize `path("")` as `path("")` for offset-path and clip-path. Differential Revision: https://phabricator.services.mozilla.com/D60771 --HG-- extra : moz-landing-system : lando
Per SVG2 spec, the EBNF allows the path data string to be empty. An empty path data string disables rendering of the path. Therefore, we should make path('') a valid path string. The related spec issue: w3c/fxtf-drafts#392. Now we serialize `path("")` as `path("")` for offset-path and clip-path. Differential Revision: https://phabricator.services.mozilla.com/D60771 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1609786 gecko-commit: 1ef31cd775e69a42d7c9b67b5ac86f65ef808b25 gecko-integration-branch: autoland gecko-reviewers: emilio
Per SVG2 spec, the EBNF allows the path data string to be empty. An empty path data string disables rendering of the path. Therefore, we should make path('') a valid path string. The related spec issue: w3c/fxtf-drafts#392. Now we serialize `path("")` as `path("")` for offset-path and clip-path. Differential Revision: https://phabricator.services.mozilla.com/D60771 UltraBlame original commit: 1ef31cd775e69a42d7c9b67b5ac86f65ef808b25
Per SVG2 spec, the EBNF allows the path data string to be empty. An empty path data string disables rendering of the path. Therefore, we should make path('') a valid path string. The related spec issue: w3c/fxtf-drafts#392. Now we serialize `path("")` as `path("")` for offset-path and clip-path. Differential Revision: https://phabricator.services.mozilla.com/D60771 UltraBlame original commit: 1ef31cd775e69a42d7c9b67b5ac86f65ef808b25
Per SVG2 spec, the EBNF allows the path data string to be empty. An empty path data string disables rendering of the path. Therefore, we should make path('') a valid path string. The related spec issue: w3c/fxtf-drafts#392. Now we serialize `path("")` as `path("")` for offset-path and clip-path. Differential Revision: https://phabricator.services.mozilla.com/D60771
Per SVG2 spec, the EBNF allows the path data string to be empty. An empty path data string disables rendering of the path. Therefore, we should make path('') a valid path string. The related spec issue: w3c/fxtf-drafts#392. Now we serialize `path("")` as `path("")` for offset-path and clip-path. Differential Revision: https://phabricator.services.mozilla.com/D60771
Per SVG2 spec, the EBNF allows the path data string to be empty. An empty path data string disables rendering of the path. Therefore, we should make path('') a valid path string. The related spec issue: w3c/fxtf-drafts#392. Now we serialize `path("")` as `path("")` for offset-path and clip-path. Differential Revision: https://phabricator.services.mozilla.com/D60771
Per SVG2 spec, the EBNF allows the path data string to be empty. An empty path data string disables rendering of the path. Therefore, we should make path('') a valid path string. The related spec issue: w3c/fxtf-drafts#392. Now we serialize `path("")` as `path("")` for offset-path and clip-path. Differential Revision: https://phabricator.services.mozilla.com/D60771
The CSS Working Group just discussed
The full IRC log of that discussion<dael> Topic: [motion-1] The computed value of offset-path: path(' ')<dael> github: https://github.com//issues/392 <dael> fantasai: I don't know much on this, but it seemed we should resolve and fix. <dael> heycam: The ultimate issue is we have path function which takes string value. string is svg data string. <dael> heycam: Some strings are invalid. What does that mean for validity of path function. If you use invalid path string inside is it all parse as invalid and dropped or is string preserved and invalidity handled later <dael> TabAtkins: If it's valid how to serialize and if not valid clarify that <dael> florian: Precedint in other properties <dael> fantasai: IN grid we throw out what's invalid after parsing <fantasai> s/Precedint/Precedent/ <dael> florian: Same here? <dael> heycam: NO reason not to <dael> florian: No architectural complexity so seems like right thing to do <dael> TabAtkins: Larger question then what's asked in issue. If you have invalid pass it's a separate question. The empty string specifically is a valid path per svg grammer but it disabled rendering of paths. Question is how is it cannonicalized and serialized. In chomre it's serialized as none. All other paths stay as paths but none doesn't so doesn't create containing block <dael> heycam: Surprises me. I think it then does not make sense to serialize as none <dael> TabAtkins: If we decide to treat as invalid that's okay with me and this solves iteself. If we want that we should record it. It's about if empty path is valid or not. <dael> florian: Is it useful? <dael> TabAtkins: No <dael> florian: THen make it invalid ad see if world breaks <dael> TabAtkins: Invalid is probably more consistent with chrome behavior <dael> fantasai: 2 resolutions? <dael> heycam: IN issues it's also mentioned strings with only whitespace. Same? <dael> florian: Suppose so <dael> TabAtkins: Yeah. Regardless of specifics of svg grammar shouldn't treat different <dael> Rossen_: can someone summerize? <dael> TabAtkins: 1) Invalid path strings make the syntax invalid at parse time <dael> Rossen_: Objections? <dael> RESOLVED: Invalid path strings make the syntax invalid at parse time <dael> TabAtkins: 2) The empty string is an invalid path string <dael> florian: With whoever does the edits being careful for all empty types <dael> fantasai: Basically 0 length path <dael> fantasai: 0 length path description <dael> TabAtkins: If we say it's empty we can deal with specifics lather <dael> florian: Empty path not empty strong <fantasai> s/strong/string <dael> Rossen_: Empty path is considered invalid <dael> Rossen_: Objections? <heycam> "a string with no path commands in it", maybe <dael> RESOLVED: Empty path is considered invalid <astearns> s/lather/later/ <dael> Rossen_: Anything else? |
Based on the definition of SVG1.1 and SVG2:
So an empty path string is valid. And then what is the expected computed value for this case?
If someone calls
getComputedStyle(div).offsetPath
, should we returnpath('')
ornone
foroffset-path
? It seems Blinks returnnone
for now. It looks like the spec doesn't mention this, anyway.The text was updated successfully, but these errors were encountered: