Gyroscope-specific construction operation and construction options #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anssiko @alexshalamov PTAL |
alexshalamov
approved these changes
Feb 8, 2018
index.bs
Outdated
| [Constructor(optional SpatialSensorOptions sensorOptions), SecureContext, Exposed=Window] | ||
| enum LocalCoordinateSystem { "device", "screen" }; | ||
|
|
||
| dictionary GyroscopeSensorOptions : SensorOptions { |
There was a problem hiding this comment.
Should the dictionary definition go after interface definition, like in other specs?
@anssiko ?
anssiko
requested changes
Feb 8, 2018
index.bs
Outdated
| [Constructor(optional SpatialSensorOptions sensorOptions), SecureContext, Exposed=Window] | ||
| enum LocalCoordinateSystem { "device", "screen" }; | ||
|
|
||
| dictionary GyroscopeSensorOptions : SensorOptions { |
There was a problem hiding this comment.
The established convention is the dictionary comes after the interface definition. And the enum comes before the interface/dictionary definition where it is referenced. So the order in this case:
interface
enum
dictionary
pozdnyakov
force-pushed
the
class_specific_constructor_params
branch
from
9ccc26c
to
d3e511c
Compare
This patch introduces the `GyroscopeSensorOptions` dictionary and the "construct a gyroscope object", thus the unneeded references to the Accelerometer specification are removed.
pozdnyakov
force-pushed
the
class_specific_constructor_params
branch
from
d3e511c
to
0fb5359
Compare
anssiko
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces the
GyroscopeSensorOptionsdictionaryand the "construct a gyroscope object", thus the unneeded references
to the Accelerometer specification are removed.
Preview | Diff