Example currently broken in latest/published versions #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, it looks like the official repos are locked from outside contributions. But this is good to know. I'll keep any changes in the official repos as |
|
Also question, since this is broken is both latest and published, Should I also open a PR with the same commit on L2 or V2, not quite sure which is which? |
|
Marked as non substantive for IPR from ash-nazg. |
plehegar
approved these changes
Oct 4, 2017
|
LGTM. No need to a separate for the published version. we'll push an update once this gets merged. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The broken example causes the highlight script to completely screw it up.
So it currently looks like this:
Preview | Diff