-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"may" instead of "must" in step 4 of <input type=image> #270
Comments
Stepping back a bit, I question whether step 4 is valid at all. For an input like: |
Step 4 is OK because input type=image is a submit button according to the specification https://html.spec.whatwg.org/multipage/input.html#image-button-state-(type=image) |
May is also OK. Alt attribute is required. No alt is a failure. Nevertheless the browser can decide to repair errors made by the author of the source code as in many other cases. But image button without alt is wrong |
I think it's worth investigating dropping step 5, especially with Edge moving to chromium. In doing so, Edge will no longer not provide a fallback string, as chromium edge falls back to a "submit" string if no accessible name is provided. @cblouch per your comment in the linked thread,
Being an |
I'm not sure if it can also be allowed to use an |
So combining the three threads, it sounds like its reasonable that browser should treat image inputs in a similar manner as submit or reset and provide a fallback string. I think the argument is stronger in the submit and reset cases, but still reasonable. Given that, the open bits are "may" vs. "must" on step 4 and whether step 5 is then needed at all. If all the browsers are (or will soon) be providing fallback text then maybe the spec should pave the cowpath and adopt "must" because the browsers are all doing it this way anyway. If step 4 goes from may to must then step 5 is obviously no longer needed. |
seems we should reuse/revise wording from
Re: step 5, I don't think this can be removed after all. For instance, even with a "must" if an author were to set |
closes #270 purposefully staying away from “MUST”, but removing the ‘may’ in this commit to stay consistent with other input button types.
closes #270 purposefully staying away from “MUST”, but removing the ‘may’ in this commit to stay consistent with other input button types.
Seems like this should be a "must" and drop step 5. As written it enables inconsistent behavior between browsers. In a quick test I found:
Safari OSX VoiceOver – “Submit Button”
Chrome OSX VoiceOver – “Submit Button”
Chrome Win10 NVDA – “Button Submit”
Chrome Win10 JAWS – “Submit Button”
Edge Win10 NVDA – “Button Blank”
Edge Win10 JAWS – “Button Blank”
FF Win10 NVDA – “Button Submit Query”
FF Win10 JAWS – “Submit Query Button”
If I am writing a test for whether a image input lacks an accessible name and have something like the ACT-R failed example 1:
https://github.com/act-rules/act-rules.github.io/blob/develop/_rules/image-button-accessible-name-59796f.md
<input type="image" name="submit" src="button.gif" />
I can't be sure if this is a fail or not because some browsers "may" supply an accessible name and some (Edge) will not. As it is today, with a test flagging or passing the above markup, I'll be generating false positives for somebody. In other words, the spec is encouraging browsers to not have interoperability.
The text was updated successfully, but these errors were encountered: