-
Notifications
You must be signed in to change notification settings - Fork 534
Reflow the links section to match sideshowbarker's proposed changes #852
Reflow the links section to match sideshowbarker's proposed changes #852
Conversation
Ok how and why ? |
attribute DOMString hreflang; | ||
attribute DOMString type; | ||
[SameObject, PutForwards=value] readonly attribute DOMTokenList sizes; | ||
[CEReactions] attribute USVString href; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to use CEReactions, it would probably be a good idea to make sure that they are defined somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would pull it out, but we have 288 total occurrences of this already in the spec. If you want to strip the spec of them completely, we should file a separate issue for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or define it... also should be seperate issue. I didn't look very carefully for as definition so maybe we do - can you please follow that up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a new issue to track this: #911
@freddyrpina mostly for readability and spec clarity :-) |
Travis, can you please check the conflicts on this branch? |
Returning to work on this; the related WHATWG PR has been merged, so the next updates will be to sync to the final version. |
Note: browsers.include some somehow switched to ANSI encoding. This merge moves it back to UTF-8.
Cool--build passed. Squash-merging this now. |
Changes in flight for issue #822