Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Reflow the links section to match sideshowbarker's proposed changes #852

Merged
merged 5 commits into from
May 19, 2017
Merged

Reflow the links section to match sideshowbarker's proposed changes #852

merged 5 commits into from
May 19, 2017

Conversation

travisleithead
Copy link
Member

Changes in flight for issue #822

@freddyrpina
Copy link

Ok how and why ?

attribute DOMString hreflang;
attribute DOMString type;
[SameObject, PutForwards=value] readonly attribute DOMTokenList sizes;
[CEReactions] attribute USVString href;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to use CEReactions, it would probably be a good idea to make sure that they are defined somewhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would pull it out, but we have 288 total occurrences of this already in the spec. If you want to strip the spec of them completely, we should file a separate issue for that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or define it... also should be seperate issue. I didn't look very carefully for as definition so maybe we do - can you please follow that up?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a new issue to track this: #911

@travisleithead
Copy link
Member Author

@freddyrpina mostly for readability and spec clarity :-)

@chaals
Copy link
Collaborator

chaals commented Apr 18, 2017

Travis, can you please check the conflicts on this branch?

@travisleithead
Copy link
Member Author

Returning to work on this; the related WHATWG PR has been merged, so the next updates will be to sync to the final version.

@travisleithead
Copy link
Member Author

Cool--build passed. Squash-merging this now.

@travisleithead travisleithead merged commit 4e4d714 into w3c:master May 19, 2017
@travisleithead travisleithead deleted the 822-refine-link-element-section branch May 19, 2017 00:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants