Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the styling of the column on the right #1687

Merged
merged 2 commits into from May 18, 2023
Merged

Conversation

xfq
Copy link
Member

@xfq xfq commented Mar 30, 2023

@xfq xfq requested a review from r12a March 30, 2023 02:28
@netlify
Copy link

netlify bot commented Mar 30, 2023

Deploy Preview for i18n-activity ready!

Name Link
🔨 Latest commit 0797281
🔍 Latest deploy log https://app.netlify.com/sites/i18n-activity/deploys/6428458d7910a60008ccf551
😎 Deploy Preview https://deploy-preview-1687--i18n-activity.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@r12a r12a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Designers tend to disapprove of using !important, and see it as a failure to write proper code. As long as this declaration appears after the link to the style sheet, there should be no problem, i think. You may have to make the rule have the same level of specificity as in the style sheet, though.

@xfq
Copy link
Member Author

xfq commented Apr 1, 2023

Designers tend to disapprove of using !important, and see it as a failure to write proper code. As long as this declaration appears after the link to the style sheet, there should be no problem, i think. You may have to make the rule have the same level of specificity as in the style sheet, though.

Thanks. Should be fixed now.

@xfq xfq merged commit a863a62 into gh-pages May 18, 2023
5 checks passed
@xfq xfq deleted the xfq/textlayout-right-column branch May 18, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants