Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Unicode character template to match specdev and tr-design #1766

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Update the Unicode character template to match specdev and tr-design #1766

merged 1 commit into from
Oct 16, 2023

Conversation

xfq
Copy link
Member

@xfq xfq commented Oct 7, 2023

No description provided.

@xfq xfq requested review from aphillips and r12a October 7, 2023 07:48
@netlify
Copy link

netlify bot commented Oct 7, 2023 •
edited

✅ Deploy Preview for i18n-activity ready!

Name Link
🔨 Latest commit b6c99df
🔍 Latest deploy log https://app.netlify.com/sites/i18n-activity/deploys/65210d5f2139c60009eb138b
😎 Deploy Preview https://deploy-preview-1766--i18n-activity.netlify.app/guidelines/editing
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xfq
Copy link
Member Author

xfq commented Oct 7, 2023

Current page: https://www.w3.org/International/i18n-activity/guidelines/editing

The preview doesn't work, because it refers to styles and scripts in another repo using relative path.

@r12a
Copy link
Contributor

r12a commented Oct 12, 2023

Although the preview doesn't work, have you carefully checked that the rendered page with changes applied is identical to the original?

@xfq
Copy link
Member Author

xfq commented Oct 13, 2023

Although the preview doesn't work, have you carefully checked that the rendered page with changes applied is identical to the original?

They are different, because the font size was changed from 85% to 0.75em.

@r12a
Copy link
Contributor

r12a commented Oct 13, 2023

Right. But does everything otherwise look ok?

@xfq
Copy link
Member Author

xfq commented Oct 16, 2023

Yes. Here's a screenshot:

unicode

@aphillips aphillips merged commit c5e86ca into gh-pages Oct 16, 2023
4 checks passed
@aphillips aphillips deleted the xfq/char-20231007 branch October 16, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphillips aphillips aphillips approved these changes

@r12a r12a r12a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xfq @r12a @aphillips