upgrade to make the checker php8 compatible #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not familiar with the code either and it looks like log4php is a dormant project per https://logging.apache.org/log4php/ I'll discuss this with @r12a. |
Thank you @xfq. Yes, we lack maintainers for that project. I did fix the errors I could find related to the PHP upgrade but I'm also far from being familiar with the code. |
r12a
approved these changes
Dec 6, 2023
xfq
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xfq @r12a, I'm creating this PR to try to upgrade the checker to make it compatible with PHP 8 as PHP 7.4 is no longer shipped with the latest stable release of debian.
That PR mainly updates the dependency to log4php and some minor scripts updates. AFAIK, it seems to work fine but I'm definitely not familiar with that checker. Can you please review the changes and let me know if I missed something? Thanks!